diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2022-05-18 15:26:55 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-18 15:26:55 +0000 |
commit | ff37b816e74091972c6722cce57338bacec6fb00 (patch) | |
tree | 7f8e64e7d020f055fb28deed010bf55050a22660 /gcc/rust/backend/rust-compile-pattern.cc | |
parent | 9e61c6eb220cf54b3fcac3d3fe7a7f1f59bcc7ad (diff) | |
parent | 7ebe376bd68eb0d9aae9cef6308f3ec15407862d (diff) | |
parent | 6c0be4876868d4afcff4acc507cf136abd066bb0 (diff) | |
download | gcc-ff37b816e74091972c6722cce57338bacec6fb00.zip gcc-ff37b816e74091972c6722cce57338bacec6fb00.tar.gz gcc-ff37b816e74091972c6722cce57338bacec6fb00.tar.bz2 |
Merge #1252 #1254
1252: privacy: Handle calls to functions defined in previous ancestors r=CohenArthur a=CohenArthur
Previously, we would only check if `current_module` was a direct
descendant of the item's module. However, we also need to visit each of this
item's module's children recursively.
1254: issue #1233: Do not rely on the endianness for testing r=CohenArthur a=CohenArthur
This testcase uncovered a very interesting bug requiring a refactor of
our `AST::Block` class (#1253), but should still be fixed/adapted in the
meantime so that the BE builds on our buildbot do not fail.
I've tested this newtestcase with a compiler from 74e836599ce80a11b1fe28065ed7aae6ffa3b7e2, which was the commit pointed out in #1233. The same ICE would still trigger, so I can safely say that this is a different exemple showing the same underlying issue. I'll work on fixing #1253 but it is a refactor we need to think about a little.
This should make all the architectures on buildbot happy again!
Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>