diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-09-10 13:30:14 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-09-10 13:30:14 +0000 |
commit | d52030df14a50ed78f388520edc9dd506b59dbee (patch) | |
tree | cae07ec30aefc20d4b6fd3c4cb512a53ee624629 /gcc/rust/backend/rust-compile-expr.h | |
parent | e93393d007276a3335839741f45865bc05787869 (diff) | |
parent | d5b259a3fd40ab9ec4d9f76b50d77eb595067f81 (diff) | |
download | gcc-d52030df14a50ed78f388520edc9dd506b59dbee.zip gcc-d52030df14a50ed78f388520edc9dd506b59dbee.tar.gz gcc-d52030df14a50ed78f388520edc9dd506b59dbee.tar.bz2 |
Merge #664
664: Fix usage of path attributes and module filename processing r=philberty a=CohenArthur
`#[path]` attributes were used wrongly in two ways:
- The attribute's value would still contain extra data such as an equal
sign and whitespaces, which need to be discarded in order to fetch the
proper file path.
- `#[path]`s are relative to the directory where the current source file
is located. So we actually need to compute them later on down the line,
once the including directory has been figured out.
Another issue was that in the case that no candidates were found, or too
many were founds, the function `process_file_path` would still return
"successfully" despite erroring out. This causes the function to return
early and thus not assign any string to the `module_file` member.
We also have the ability to emit an error for the module's location,
which looks better for the user, instead of using a new `Location()`
like the session manager does (because it cannot do otherwise, as it
is starting to parse a file and thus has no file location information)
Co-authored-by: CohenArthur <arthur.cohen@epita.fr>
Diffstat (limited to 'gcc/rust/backend/rust-compile-expr.h')
0 files changed, 0 insertions, 0 deletions