diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2017-11-28 21:45:56 +0000 |
|---|---|---|
| committer | David Malcolm <dmalcolm@gcc.gnu.org> | 2017-11-28 21:45:56 +0000 |
| commit | 64ea27f0d26d943241e4d91dc30464cfe7be245c (patch) | |
| tree | ddb1c2a17409e23bb079ed3fde000da92cfa6021 /gcc/rtlanal.c | |
| parent | 1a2e970832f6076e76adc06b42c106bdb568a86c (diff) | |
| download | gcc-64ea27f0d26d943241e4d91dc30464cfe7be245c.zip gcc-64ea27f0d26d943241e4d91dc30464cfe7be245c.tar.gz gcc-64ea27f0d26d943241e4d91dc30464cfe7be245c.tar.bz2 | |
Handle very long lines when printing fix-it hints
When fixing PR c/82050 I noticed a bug in how we print fix-it hints
for very long lines: we weren't taking into account the x-offset for
the line when printing the fix-it hint.
This could lead to output where instead of printing:
foo.c:14:3944: error: etc
= foo.field
^~~~~
replacement
where the lines have been offset to start printing at about column 3900,
the "replacement" line was erroneously *not* offset, and was thus
prefixed by thousands of spaces, leading to large whitespace gaps in
the output, and the replacement failing to line up with the source to be
replaced.
Fixed thusly.
gcc/ChangeLog:
* diagnostic-show-locus.c (layout::print_trailing_fixits): Handle
m_x_offset.
(layout::move_to_column): Likewise.
gcc/testsuite/ChangeLog:
* gcc.dg/plugin/diagnostic-test-show-locus-bw.c
(test_very_wide_line): Update expected output to include a
fix-it hint.
* gcc.dg/plugin/diagnostic-test-show-locus-color.c
(test_very_wide_line): Likewise.
* gcc.dg/plugin/diagnostic_plugin_test_show_locus.c
(test_show_locus): Add a fix-it hint to "test_very_wide_line".
From-SVN: r255219
Diffstat (limited to 'gcc/rtlanal.c')
0 files changed, 0 insertions, 0 deletions