diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2021-01-16 09:17:38 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2021-01-16 09:20:29 +0100 |
| commit | b673e7547fb95d1f0d5cd17ae9e3874742cade66 (patch) | |
| tree | 902a5f562ddc765c1e4788ea54154f00aba50733 /gcc/passes.def | |
| parent | 2c356f221bbab29bf4d1626d161e0f584dddd600 (diff) | |
| download | gcc-b673e7547fb95d1f0d5cd17ae9e3874742cade66.zip gcc-b673e7547fb95d1f0d5cd17ae9e3874742cade66.tar.gz gcc-b673e7547fb95d1f0d5cd17ae9e3874742cade66.tar.bz2 | |
cd_dce: Return TODO_update_address_taken from last cd_dce [PR96271]
On the following testcase, handle_builtin_memcmp in the strlen pass folds
the memcmp into comparison of two MEM_REFs. But nothing triggers updating
of addressable vars afterwards, so even when the parameters are no longer
address taken, we force the parameters to stack and back anyway.
This patch causes TODO_update_address_taken to happen right before last forwprop
pass (at the end of last cd_dce), so after strlen1 too.
2021-01-16 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/96271
* passes.def: Pass false argument to first two pass_cd_dce
instances and true to last instance. Add comment that
last instance rewrites no longer addressed locals.
* tree-ssa-dce.c (pass_cd_dce): Add update_address_taken_p member and
initialize it.
(pass_cd_dce::set_pass_param): New method.
(pass_cd_dce::execute): Return TODO_update_address_taken from
last cd_dce instance.
* gcc.target/i386/pr96271.c: New test.
Diffstat (limited to 'gcc/passes.def')
| -rw-r--r-- | gcc/passes.def | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/gcc/passes.def b/gcc/passes.def index c8e01ae..e9ed3c7 100644 --- a/gcc/passes.def +++ b/gcc/passes.def @@ -90,7 +90,7 @@ along with GCC; see the file COPYING3. If not see NEXT_PASS (pass_early_vrp); NEXT_PASS (pass_merge_phi); NEXT_PASS (pass_dse); - NEXT_PASS (pass_cd_dce); + NEXT_PASS (pass_cd_dce, false /* update_address_taken_p */); NEXT_PASS (pass_phiopt, true /* early_p */); NEXT_PASS (pass_modref); NEXT_PASS (pass_tail_recursion); @@ -272,7 +272,7 @@ along with GCC; see the file COPYING3. If not see NEXT_PASS (pass_loop_jam); /* All unswitching, final value replacement and splitting can expose empty loops. Remove them now. */ - NEXT_PASS (pass_cd_dce); + NEXT_PASS (pass_cd_dce, false /* update_address_taken_p */); NEXT_PASS (pass_iv_canon); NEXT_PASS (pass_loop_distribution); NEXT_PASS (pass_linterchange); @@ -336,7 +336,9 @@ along with GCC; see the file COPYING3. If not see NEXT_PASS (pass_copy_prop); NEXT_PASS (pass_warn_restrict); NEXT_PASS (pass_dse); - NEXT_PASS (pass_cd_dce); + NEXT_PASS (pass_cd_dce, true /* update_address_taken_p */); + /* After late CD DCE we rewrite no longer addressed locals into SSA + form if possible. */ NEXT_PASS (pass_forwprop); NEXT_PASS (pass_phiopt, false /* early_p */); NEXT_PASS (pass_fold_builtins); |