diff options
| author | Vladimir Makarov <vmakarov@redhat.com> | 2013-01-30 17:20:39 +0000 |
|---|---|---|
| committer | Vladimir Makarov <vmakarov@gcc.gnu.org> | 2013-01-30 17:20:39 +0000 |
| commit | 73cca0cc94027192b06c8b7897fe5fbe20de566e (patch) | |
| tree | e8f9d6d245207058ab1c9ff579bc2e00dd067178 /gcc/lra-constraints.c | |
| parent | 162b4e41267d991038ff159a28a78388608a99ff (diff) | |
| download | gcc-73cca0cc94027192b06c8b7897fe5fbe20de566e.zip gcc-73cca0cc94027192b06c8b7897fe5fbe20de566e.tar.gz gcc-73cca0cc94027192b06c8b7897fe5fbe20de566e.tar.bz2 | |
re PR rtl-optimization/56144 (ICE in get_reload_reg, at lra-constraints.c:421)
2013-01-30 Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/56144
* lra-constraints.c (get_reload_reg): Don't reuse reload pseudo
for values with side effects.
2013-01-30 Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/56144
* gcc.dg/pr56144.c: New.
From-SVN: r195582
Diffstat (limited to 'gcc/lra-constraints.c')
| -rw-r--r-- | gcc/lra-constraints.c | 38 |
1 files changed, 20 insertions, 18 deletions
diff --git a/gcc/lra-constraints.c b/gcc/lra-constraints.c index 03728b7..cc28854 100644 --- a/gcc/lra-constraints.c +++ b/gcc/lra-constraints.c @@ -414,24 +414,26 @@ get_reload_reg (enum op_type type, enum machine_mode mode, rtx original, = lra_create_new_reg_with_unique_value (mode, original, rclass, title); return true; } - for (i = 0; i < curr_insn_input_reloads_num; i++) - if (rtx_equal_p (curr_insn_input_reloads[i].input, original) - && in_class_p (curr_insn_input_reloads[i].reg, rclass, &new_class)) - { - lra_assert (! side_effects_p (original)); - *result_reg = curr_insn_input_reloads[i].reg; - regno = REGNO (*result_reg); - if (lra_dump_file != NULL) - { - fprintf (lra_dump_file, " Reuse r%d for reload ", regno); - dump_value_slim (lra_dump_file, original, 1); - } - if (new_class != lra_get_allocno_class (regno)) - change_class (regno, new_class, ", change", false); - if (lra_dump_file != NULL) - fprintf (lra_dump_file, "\n"); - return false; - } + /* Prevent reuse value of expression with side effects, + e.g. volatile memory. */ + if (! side_effects_p (original)) + for (i = 0; i < curr_insn_input_reloads_num; i++) + if (rtx_equal_p (curr_insn_input_reloads[i].input, original) + && in_class_p (curr_insn_input_reloads[i].reg, rclass, &new_class)) + { + *result_reg = curr_insn_input_reloads[i].reg; + regno = REGNO (*result_reg); + if (lra_dump_file != NULL) + { + fprintf (lra_dump_file, " Reuse r%d for reload ", regno); + dump_value_slim (lra_dump_file, original, 1); + } + if (new_class != lra_get_allocno_class (regno)) + change_class (regno, new_class, ", change", false); + if (lra_dump_file != NULL) + fprintf (lra_dump_file, "\n"); + return false; + } *result_reg = lra_create_new_reg (mode, original, rclass, title); lra_assert (curr_insn_input_reloads_num < LRA_MAX_INSN_RELOADS); curr_insn_input_reloads[curr_insn_input_reloads_num].input = original; |