aboutsummaryrefslogtreecommitdiff
path: root/gcc/java
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2013-12-19 22:27:51 +0100
committerJakub Jelinek <jakub@gcc.gnu.org>2013-12-19 22:27:51 +0100
commite15eb172b0dd7451f121c908a97ab86a45759993 (patch)
tree0dd1c959d5fa1a9b4256002c3671f2654e454c31 /gcc/java
parentd8d79c1df220d94f4c285e0a6e1e750bfb488d78 (diff)
downloadgcc-e15eb172b0dd7451f121c908a97ab86a45759993.zip
gcc-e15eb172b0dd7451f121c908a97ab86a45759993.tar.gz
gcc-e15eb172b0dd7451f121c908a97ab86a45759993.tar.bz2
re PR other/59545 (Signed integer overflow issues)
PR other/59545 * genattrtab.c (struct attr_hash): Change hashcode type to unsigned. (attr_hash_add_rtx, attr_hash_add_string): Change hashcode parameter to unsigned. (attr_rtx_1): Change hashcode variable to unsigned. (attr_string): Likewise. Perform first multiplication in unsigned type. * ifcvt.c (noce_try_store_flag_constants): Avoid signed integer overflows. * double-int.c (neg_double): Likewise. * stor-layout.c (set_min_and_max_values_for_integral_type): Likewise. * combine.c (force_to_mode): Likewise. * postreload.c (move2add_use_add2_insn, move2add_use_add3_insn, reload_cse_move2add, move2add_note_store): Likewise. * simplify-rtx.c (simplify_const_unary_operation, simplify_const_binary_operation): Likewise. * ipa-split.c (find_split_points): Initialize first.can_split and first.non_ssa_vars. * gengtype-state.c (read_state_files_list): Fix up check. * genautomata.c (reserv_sets_hash_value): Use portable rotation idiom. java/ * class.c (hashUtf8String): Compute hash in unsigned type. * javaop.h (WORD_TO_INT): Avoid signed integer overflow. From-SVN: r206134
Diffstat (limited to 'gcc/java')
-rw-r--r--gcc/java/ChangeLog6
-rw-r--r--gcc/java/class.c2
-rw-r--r--gcc/java/javaop.h2
3 files changed, 8 insertions, 2 deletions
diff --git a/gcc/java/ChangeLog b/gcc/java/ChangeLog
index 3b8a95a..5ab1921 100644
--- a/gcc/java/ChangeLog
+++ b/gcc/java/ChangeLog
@@ -1,3 +1,9 @@
+2013-12-19 Jakub Jelinek <jakub@redhat.com>
+
+ PR other/59545
+ * class.c (hashUtf8String): Compute hash in unsigned type.
+ * javaop.h (WORD_TO_INT): Avoid signed integer overflow.
+
2013-11-22 Andrew MacLeod <amacleod@redhat.com>
* java-gimplify.c: Add required include files from gimple.h.
diff --git a/gcc/java/class.c b/gcc/java/class.c
index 532c9c1..e5d2e6d 100644
--- a/gcc/java/class.c
+++ b/gcc/java/class.c
@@ -920,7 +920,7 @@ hashUtf8String (const char *str, int len)
{
const unsigned char* ptr = (const unsigned char*) str;
const unsigned char *limit = ptr + len;
- int32 hash = 0;
+ uint32 hash = 0;
for (; ptr < limit;)
{
int ch = UTF8_GET (ptr, limit);
diff --git a/gcc/java/javaop.h b/gcc/java/javaop.h
index 574c10c..bffa857 100644
--- a/gcc/java/javaop.h
+++ b/gcc/java/javaop.h
@@ -154,7 +154,7 @@ WORD_TO_INT(jword w)
{
jint n = w & 0xffffffff; /* Mask lower 32 bits. */
n ^= (jint)1 << 31;
- n -= (jint)1 << 31; /* Sign extend lower 32 bits to upper. */
+ n -= (uint32)1 << 31; /* Sign extend lower 32 bits to upper. */
return n;
}