diff options
| author | Tom Tromey <tromey@redhat.com> | 2002-05-07 03:32:01 +0000 |
|---|---|---|
| committer | Tom Tromey <tromey@gcc.gnu.org> | 2002-05-07 03:32:01 +0000 |
| commit | 486e8c0cd34a187feb4adf908c183274a93cb654 (patch) | |
| tree | 7159ea0ab41b06803b073585f69939e4604b03d4 /gcc/java/parse.y | |
| parent | 61e0b50fd7a184cc5f611a0bbaceabc44fa6eb0f (diff) | |
| download | gcc-486e8c0cd34a187feb4adf908c183274a93cb654.zip gcc-486e8c0cd34a187feb4adf908c183274a93cb654.tar.gz gcc-486e8c0cd34a187feb4adf908c183274a93cb654.tar.bz2 | |
re PR java/5941 (incorrect "Unreachable statement" error)
Fix for PR java/5941:
* parse.y (finish_for_loop): Set SUPPRESS_UNREACHABLE_ERROR for
loop update expression.
(java_complete_lhs): Use SUPPRESS_UNREACHABLE_ERROR.
* java-tree.h (SUPPRESS_UNREACHABLE_ERROR): New macro.
From-SVN: r53247
Diffstat (limited to 'gcc/java/parse.y')
| -rw-r--r-- | gcc/java/parse.y | 29 |
1 files changed, 27 insertions, 2 deletions
diff --git a/gcc/java/parse.y b/gcc/java/parse.y index c45ff1e..526850d 100644 --- a/gcc/java/parse.y +++ b/gcc/java/parse.y @@ -11842,7 +11842,17 @@ java_complete_lhs (node) if (TREE_CODE (nn) != EXIT_EXPR) { SET_WFL_OPERATOR (wfl_operator, node, wfl_op2); - parse_error_context (wfl_operator, "Unreachable statement"); + if (SUPPRESS_UNREACHABLE_ERROR (nn)) + { + /* Perhaps this warning should have an + associated flag. The code being compiled is + pedantically correct, but useless. */ + parse_warning_context (wfl_operator, + "Unreachable statement"); + } + else + parse_error_context (wfl_operator, + "Unreachable statement"); } } TREE_OPERAND (node, 1) = java_complete_tree (TREE_OPERAND (node, 1)); @@ -14981,7 +14991,22 @@ finish_for_loop (location, condition, update, body) /* Put the condition and the loop body in place */ tree loop = finish_loop_body (location, condition, body, 0); /* LOOP is the current loop which has been now popped of the loop - stack. Install the update block */ + stack. Mark the update block as reachable and install it. We do + this because the (current interpretation of the) JLS requires + that the update expression be considered reachable even if the + for loop's body doesn't complete normally. */ + if (update != NULL_TREE && update != empty_stmt_node) + { + tree up2 = update; + if (TREE_CODE (up2) == EXPR_WITH_FILE_LOCATION) + up2 = EXPR_WFL_NODE (up2); + /* Try to detect constraint violations. These would be + programming errors somewhere. */ + if (! IS_EXPR_CODE_CLASS (TREE_CODE_CLASS (TREE_CODE (up2))) + | TREE_CODE (up2) == LOOP_EXPR) + abort (); + SUPPRESS_UNREACHABLE_ERROR (up2) = 1; + } LOOP_EXPR_BODY_UPDATE_BLOCK (LOOP_EXPR_BODY (loop)) = update; return loop; } |