diff options
| author | Jan Hubicka <jh@suse.cz> | 2010-10-26 18:40:16 +0200 |
|---|---|---|
| committer | Jan Hubicka <hubicka@gcc.gnu.org> | 2010-10-26 16:40:16 +0000 |
| commit | 530f3a1bf62964c0c52d6fcf4ca0d321ce9d5156 (patch) | |
| tree | f4fc3981e343130fc38f5d142b14b9d00708d62f /gcc/ipa-cp.c | |
| parent | 0d600fce5ba0aae8073f84b9c5f9296233f6f269 (diff) | |
| download | gcc-530f3a1bf62964c0c52d6fcf4ca0d321ce9d5156.zip gcc-530f3a1bf62964c0c52d6fcf4ca0d321ce9d5156.tar.gz gcc-530f3a1bf62964c0c52d6fcf4ca0d321ce9d5156.tar.bz2 | |
re PR lto/45736 (ICE: in cgraph_remove_unreachable_nodes, at ipa.c:245 with -flto and attribute((constructor)))
PR middle-end/45736
* cgraph.c (cgraph_set_readonly_flag): Rename to...
(cgraph_set_const_flags) ... this one; get also looping argument;
clear constructor/destructor flags.
(cgraph_set_pure_flag): Likewise.
(cgraph_set_looping_const_or_pure_flag): Remove.
(cgraph_can_remove_if_no_direct_calls_and_refs): Do not try
to optimize away static ctors/dtors; it does not work on inline clones;
external functions can always be rmeoved.
(cgraph_will_be_removed_from_program_if_no_direct_calls): Assert on inline
clones; in LTO external functions always can go.
(cgraph_used_from_object_file_p): Handle EXTERNAL functions correctly.
(cgraph_mark_address_taken_node): Assert that we are not taking address of
inline clone.
(cgraph_can_remove_if_no_direct_calls_p): We always eventually remove
external functions.
* ipa-cp.c (ipcp_cloning_candidate_p): Do not clone functions with address taken.
(ipcp_initialize_node_lattices): Only local functions can be handled without cloning.
* cgraph.h (cgraph_set_readonly_flag,
cgraph_set_looping_const_or_pure_flag): Remove.
(cgraph_set_const_flag): Declare.
(cgraph_set_pure_flag): Update.
* ipa-pure-const (propagate_pure_const, local_pure_const): Update
flags setting code.
* ipa.c (cgraph_remove_unreachable_nodes): Fix formating; do not look at inline
clones; fix handling of external definitions.
(cgraph_postorder): Do not look at inline clones in the first pass.
(function_and_variable_visibility): Drop constructors/destructor
flags at pure and const functions.
* tree-profile.c (tree_profiling): Update.
* ipa-inline.c (cgraph_clone_inlined_nodes): Always clone functions with
address taken; external functions do not account to whole program size.
(cgraph_decide_inlining): Likewise; do not try to inline functions already
inlined.
* testsuite/gcc.dg/lto/pr45736_0.c: New function.
From-SVN: r165972
Diffstat (limited to 'gcc/ipa-cp.c')
| -rw-r--r-- | gcc/ipa-cp.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index 140dfc0..33ed496 100644 --- a/gcc/ipa-cp.c +++ b/gcc/ipa-cp.c @@ -457,6 +457,15 @@ ipcp_cloning_candidate_p (struct cgraph_node *node) if (cgraph_only_called_directly_p (node) || !node->analyzed) return false; + /* When function address is taken, we are pretty sure it will be called in hidden way. */ + if (node->address_taken) + { + if (dump_file) + fprintf (dump_file, "Not considering %s for cloning; address is taken.\n", + cgraph_node_name (node)); + return false; + } + if (cgraph_function_body_availability (node) <= AVAIL_OVERWRITABLE) { if (dump_file) @@ -561,7 +570,7 @@ ipcp_initialize_node_lattices (struct cgraph_node *node) if (ipa_is_called_with_var_arguments (info)) type = IPA_BOTTOM; - else if (cgraph_only_called_directly_p (node)) + else if (node->local.local) type = IPA_TOP; /* When cloning is allowed, we can assume that externally visible functions are not called. We will compensate this by cloning later. */ |