diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2007-01-24 21:58:21 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2007-01-24 21:58:21 +0100 |
| commit | 07b7aade9dd819cff10a92a718fd2226cafaef1e (patch) | |
| tree | e3b0b87469cd96d6afc98081bf8d71bc30adac60 /gcc/gimplify.c | |
| parent | 4288fea21277dfd56522378ce31ae2461a299303 (diff) | |
| download | gcc-07b7aade9dd819cff10a92a718fd2226cafaef1e.zip gcc-07b7aade9dd819cff10a92a718fd2226cafaef1e.tar.gz gcc-07b7aade9dd819cff10a92a718fd2226cafaef1e.tar.bz2 | |
re PR middle-end/27416 (ICE on invalid firstprivate/lastprivate)
PR middle-end/27416
* gimplify.c (omp_check_private): New function.
(gimplify_scan_omp_clauses): Use it for
firstprivate/lastprivate/reduction.
* gcc.dg/gomp/pr27416.c: New test.
From-SVN: r121133
Diffstat (limited to 'gcc/gimplify.c')
| -rw-r--r-- | gcc/gimplify.c | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/gcc/gimplify.c b/gcc/gimplify.c index be02fb2..19323ae 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -4667,6 +4667,31 @@ omp_is_private (struct gimplify_omp_ctx *ctx, tree decl) return !is_global_var (decl); } +/* Return true if DECL is private within a parallel region + that binds to the current construct's context or in parallel + region's REDUCTION clause. */ + +static bool +omp_check_private (struct gimplify_omp_ctx *ctx, tree decl) +{ + splay_tree_node n; + + do + { + ctx = ctx->outer_context; + if (ctx == NULL) + return !(is_global_var (decl) + /* References might be private, but might be shared too. */ + || lang_hooks.decls.omp_privatize_by_reference (decl)); + + n = splay_tree_lookup (ctx->variables, (splay_tree_key) decl); + if (n != NULL) + return (n->value & GOVD_SHARED) == 0; + } + while (!ctx->is_parallel); + return false; +} + /* Scan the OpenMP clauses in *LIST_P, installing mappings into a new and previous omp contexts. */ @@ -4685,6 +4710,7 @@ gimplify_scan_omp_clauses (tree *list_p, tree *pre_p, bool in_parallel, enum gimplify_status gs; bool remove = false; bool notice_outer = true; + const char *check_non_private = NULL; unsigned int flags; tree decl; @@ -4699,12 +4725,15 @@ gimplify_scan_omp_clauses (tree *list_p, tree *pre_p, bool in_parallel, goto do_add; case OMP_CLAUSE_FIRSTPRIVATE: flags = GOVD_FIRSTPRIVATE | GOVD_EXPLICIT; + check_non_private = "firstprivate"; goto do_add; case OMP_CLAUSE_LASTPRIVATE: flags = GOVD_LASTPRIVATE | GOVD_SEEN | GOVD_EXPLICIT; + check_non_private = "lastprivate"; goto do_add; case OMP_CLAUSE_REDUCTION: flags = GOVD_REDUCTION | GOVD_SEEN | GOVD_EXPLICIT; + check_non_private = "reduction"; goto do_add; do_add: @@ -4754,6 +4783,14 @@ gimplify_scan_omp_clauses (tree *list_p, tree *pre_p, bool in_parallel, do_notice: if (outer_ctx) omp_notice_variable (outer_ctx, decl, true); + if (check_non_private + && !in_parallel + && omp_check_private (ctx, decl)) + { + error ("%s variable %qs is private in outer context", + check_non_private, IDENTIFIER_POINTER (DECL_NAME (decl))); + remove = true; + } break; case OMP_CLAUSE_IF: |