diff options
author | Jakub Jelinek <jakub@redhat.com> | 2020-10-21 10:21:52 +0200 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2020-10-21 10:21:52 +0200 |
commit | 121a8812c45b3155ccbd268b000ad00a778e81e8 (patch) | |
tree | af92e526851805c8e1c4eedd7b3da0b209f954ce /gcc/fortran/class.c | |
parent | bae73ca5222381861a29202c88ce5cfe675b6753 (diff) | |
download | gcc-121a8812c45b3155ccbd268b000ad00a778e81e8.zip gcc-121a8812c45b3155ccbd268b000ad00a778e81e8.tar.gz gcc-121a8812c45b3155ccbd268b000ad00a778e81e8.tar.bz2 |
libgomp: Hopefully avoid false positive warnings in env.c on solaris
> the patch also breaks bootstrap on both i386-pc-solaris2.11 and
> sparc-sun-solaris2.11:
>
> /vol/gcc/src/hg/master/local/libgomp/env.c: In function 'initialize_env':
> /vol/gcc/src/hg/master/local/libgomp/env.c:414:16: error: 'new_offload' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 414 | *offload = new_offload;
> | ~~~~~~~~~^~~~~~~~~~~~~
> /vol/gcc/src/hg/master/local/libgomp/env.c:384:30: note: 'new_offload' was declared here
> 384 | enum gomp_target_offload_t new_offload;
> | ^~~~~~~~~~~
I can't reproduce that, but I fail to see why we need two separate
variables, one with actual value and one tracking if the value is valid.
So, I'm going with:
2020-10-21 Jakub Jelinek <jakub@redhat.com>
* env.c (parse_target_offload): Change new_offload var type to int,
preinitialize to -1, remove found var and test new_offload != -1
instead of found.
Diffstat (limited to 'gcc/fortran/class.c')
0 files changed, 0 insertions, 0 deletions