aboutsummaryrefslogtreecommitdiff
path: root/gcc/fortran/check.c
diff options
context:
space:
mode:
authorSteven G. Kargl <kargl@gcc.gnu.org>2011-10-21 22:48:39 +0000
committerSteven G. Kargl <kargl@gcc.gnu.org>2011-10-21 22:48:39 +0000
commit6d8c9e5c9a37743e22836e9621fb5f865b97a3e3 (patch)
tree9cb3e25e366ce27408189d086dbe4d0f4fdc9023 /gcc/fortran/check.c
parent74b388c3393db06df440d0774261b420639e8a97 (diff)
downloadgcc-6d8c9e5c9a37743e22836e9621fb5f865b97a3e3.zip
gcc-6d8c9e5c9a37743e22836e9621fb5f865b97a3e3.tar.gz
gcc-6d8c9e5c9a37743e22836e9621fb5f865b97a3e3.tar.bz2
re PR fortran/50821 (3 new GCC HEAD@180266 regressions)
2011-10-20 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/50821 * check.c (gfc_check_ishftc): Check args are constant before extracting the integer. From-SVN: r180316
Diffstat (limited to 'gcc/fortran/check.c')
-rw-r--r--gcc/fortran/check.c33
1 files changed, 20 insertions, 13 deletions
diff --git a/gcc/fortran/check.c b/gcc/fortran/check.c
index 9aaad01..34b3a68 100644
--- a/gcc/fortran/check.c
+++ b/gcc/fortran/check.c
@@ -1967,22 +1967,29 @@ gfc_check_ishftc (gfc_expr *i, gfc_expr *shift, gfc_expr *size)
if (less_than_bitsize1 ("I", i, "SIZE", size, true) == FAILURE)
return FAILURE;
- gfc_extract_int (size, &i3);
- if (i3 <= 0)
+ if (size->expr_type == EXPR_CONSTANT)
{
- gfc_error ("SIZE at %L must be positive", &size->where);
- return FAILURE;
- }
+ gfc_extract_int (size, &i3);
+ if (i3 <= 0)
+ {
+ gfc_error ("SIZE at %L must be positive", &size->where);
+ return FAILURE;
+ }
- gfc_extract_int (shift, &i2);
- if (i2 < 0)
- i2 = -i2;
+ if (shift->expr_type == EXPR_CONSTANT)
+ {
+ gfc_extract_int (shift, &i2);
+ if (i2 < 0)
+ i2 = -i2;
- if (i2 > i3)
- {
- gfc_error ("The absolute value of SHIFT at %L must be less than "
- "or equal to SIZE at %L", &shift->where, &size->where);
- return FAILURE;
+ if (i2 > i3)
+ {
+ gfc_error ("The absolute value of SHIFT at %L must be less "
+ "than or equal to SIZE at %L", &shift->where,
+ &size->where);
+ return FAILURE;
+ }
+ }
}
}
else if (less_than_bitsize1 ("I", i, NULL, shift, true) == FAILURE)