aboutsummaryrefslogtreecommitdiff
path: root/gcc/expr.h
diff options
context:
space:
mode:
authorDavid Malcolm <dmalcolm@redhat.com>2018-08-16 22:33:00 +0000
committerDavid Malcolm <dmalcolm@gcc.gnu.org>2018-08-16 22:33:00 +0000
commit5c6a2bf2720fd6412a2d63a3a82da5af0c18f824 (patch)
tree8288ba2c095a7579fae973b7e47977f8190e81d2 /gcc/expr.h
parent5218dafdc219eb49a0b8d776b99fd7a7afb5be0b (diff)
downloadgcc-5c6a2bf2720fd6412a2d63a3a82da5af0c18f824.zip
gcc-5c6a2bf2720fd6412a2d63a3a82da5af0c18f824.tar.gz
gcc-5c6a2bf2720fd6412a2d63a3a82da5af0c18f824.tar.bz2
diagnostics: fix bad interaction between line spans and line numbers
Without this patch, the "line span" markers and the line numbering interacted badly, leading to stray copies of the line-span markers appearing as prefixes on the first source line in a span: missing-header-fixit-3.c: In function 'test': missing-header-fixit-3.c:9:3: warning: implicit declaration of function 'printf' [-Wimplicit-function-declaration] 9 | printf ("%i of %i\n", i, j); | ^~~~~~ missing-header-fixit-3.c:9:3: warning: incompatible implicit declaration of built-in function 'printf' missing-header-fixit-3.c:9:3: note: include '<stdio.h>' or provide a declaration of 'printf' missing-header-fixit-3.c:1:1: |+#include <stdio.h> missing-header-fixit-3.c:1:1:1 | /* Example of a fix-it hint that adds a #include directive, missing-header-fixit-3.c:9:3: missing-header-fixit-3.c:9:3:9 | printf ("%i of %i\n", i, j); | ^~~~~~ With this patch, we now correctly print: missing-header-fixit-3.c: In function 'test': missing-header-fixit-3.c:9:3: warning: implicit declaration of function 'printf' [-Wimplicit-function-declaration] 9 | printf ("%i of %i\n", i, j); | ^~~~~~ missing-header-fixit-3.c:9:3: warning: incompatible implicit declaration of built-in function 'printf' missing-header-fixit-3.c:9:3: note: include '<stdio.h>' or provide a declaration of 'printf' missing-header-fixit-3.c:1:1: + |+#include <stdio.h> 1 | /* Example of a fix-it hint that adds a #include directive, missing-header-fixit-3.c:9:3: 9 | printf ("%i of %i\n", i, j); | ^~~~~~ gcc/ChangeLog: * diagnostic.c (default_diagnostic_start_span_fn): Call pp_string to emit the span, rather than setting it as the prefix. gcc/testsuite/ChangeLog: * gcc.dg/missing-header-fixit-3.c: New test. From-SVN: r263606
Diffstat (limited to 'gcc/expr.h')
0 files changed, 0 insertions, 0 deletions