diff options
author | Andrew Pinski <quic_apinski@quicinc.com> | 2024-01-23 17:42:51 +0000 |
---|---|---|
committer | Richard Sandiford <richard.sandiford@arm.com> | 2024-01-23 17:42:51 +0000 |
commit | 06ee648e9bb8c121fbd93659f81d3380dba8be09 (patch) | |
tree | b11f086d76a5dcb8dd149b4afacb2a7747382b81 /gcc/expr.h | |
parent | cc082cf97e21dad37c4983572218a22ce0c3036c (diff) | |
download | gcc-06ee648e9bb8c121fbd93659f81d3380dba8be09.zip gcc-06ee648e9bb8c121fbd93659f81d3380dba8be09.tar.gz gcc-06ee648e9bb8c121fbd93659f81d3380dba8be09.tar.bz2 |
aarch64/expr: Use ccmp when the outer expression is used twice [PR100942]
Ccmp is not used if the result of the and/ior is used by both
a GIMPLE_COND and a GIMPLE_ASSIGN. This improves the code generation
here by using ccmp in this case.
Two changes is required, first we need to allow the outer statement's
result be used more than once.
The second change is that during the expansion of the gimple, we need
to try using ccmp. This is needed because we don't use expand the ssa
name of the lhs but rather expand directly from the gimple.
A small note on the ccmp_4.c testcase, we should be able to get slightly
better than with this patch but it is one extra instruction compared to
before.
PR target/100942
gcc/ChangeLog:
* ccmp.cc (ccmp_candidate_p): Add outer argument.
Allow if the outer is true and the lhs is used more
than once.
(expand_ccmp_expr): Update call to ccmp_candidate_p.
* expr.h (expand_expr_real_gassign): Declare.
* expr.cc (expand_expr_real_gassign): New function, split out from...
(expand_expr_real_1): ...here.
* cfgexpand.cc (expand_gimple_stmt_1): Use expand_expr_real_gassign.
gcc/testsuite/ChangeLog:
* gcc.target/aarch64/ccmp_3.c: New test.
* gcc.target/aarch64/ccmp_4.c: New test.
* gcc.target/aarch64/ccmp_5.c: New test.
Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
Co-Authored-By: Richard Sandiford <richard.sandiford@arm.com>
Diffstat (limited to 'gcc/expr.h')
-rw-r--r-- | gcc/expr.h | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -302,6 +302,9 @@ extern rtx expand_expr_real_1 (tree, rtx, machine_mode, enum expand_modifier, rtx *, bool); extern rtx expand_expr_real_2 (sepops, rtx, machine_mode, enum expand_modifier); +extern rtx expand_expr_real_gassign (gassign *, rtx, machine_mode, + enum expand_modifier modifier, + rtx * = nullptr, bool = false); /* Generate code for computing expression EXP. An rtx for the computed value is returned. The value is never null. |