diff options
| author | Andrew Pinski <apinski@marvell.com> | 2023-05-19 18:36:39 +0000 |
|---|---|---|
| committer | Andrew Pinski <apinski@marvell.com> | 2023-05-20 05:04:49 +0000 |
| commit | 9d2fdcab162365caa23e5ade92d1404737e9b600 (patch) | |
| tree | 9cf4e26c46df60d929298c8f3bd55b76e91abb63 /gcc/expr.cc | |
| parent | 3b537ab625ee7dac4f1d601b55b5b623d61d1119 (diff) | |
| download | gcc-9d2fdcab162365caa23e5ade92d1404737e9b600.zip gcc-9d2fdcab162365caa23e5ade92d1404737e9b600.tar.gz gcc-9d2fdcab162365caa23e5ade92d1404737e9b600.tar.bz2 | |
Simplify fold_single_bit_test slightly
Now the only use of fold_single_bit_test is in do_store_flag,
we can change it such that to pass the inner arg and bitnum
instead of building a tree. There is no code generation changes
due to this change, only a decrease in GC memory that is produced
during expansion.
gcc/ChangeLog:
* expr.cc (fold_single_bit_test): Take inner and bitnum
instead of arg0 and arg1. Update the code.
(do_store_flag): Don't create a tree when calling
fold_single_bit_test instead just call it with the bitnum
and the inner tree.
Diffstat (limited to 'gcc/expr.cc')
| -rw-r--r-- | gcc/expr.cc | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/gcc/expr.cc b/gcc/expr.cc index a61772b..67a9f82 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -12899,23 +12899,19 @@ maybe_optimize_sub_cmp_0 (enum tree_code code, tree *arg0, tree *arg1) } -/* If CODE with arguments ARG0 and ARG1 represents a single bit +/* If CODE with arguments INNER & (1<<BITNUM) and 0 represents a single bit equality/inequality test, then return a simplified form of the test using shifts and logical operations. Otherwise return NULL. TYPE is the desired result type. */ static tree fold_single_bit_test (location_t loc, enum tree_code code, - tree arg0, tree arg1, tree result_type) + tree inner, int bitnum, + tree result_type) { - /* If this is testing a single bit, we can optimize the test. */ - if ((code == NE_EXPR || code == EQ_EXPR) - && TREE_CODE (arg0) == BIT_AND_EXPR && integer_zerop (arg1) - && integer_pow2p (TREE_OPERAND (arg0, 1))) + if ((code == NE_EXPR || code == EQ_EXPR)) { - tree inner = TREE_OPERAND (arg0, 0); - tree type = TREE_TYPE (arg0); - int bitnum = tree_log2 (TREE_OPERAND (arg0, 1)); + tree type = TREE_TYPE (inner); scalar_int_mode operand_mode = SCALAR_INT_TYPE_MODE (type); int ops_unsigned; tree signed_type, unsigned_type, intermediate_type; @@ -13170,12 +13166,14 @@ do_store_flag (sepops ops, rtx target, machine_mode mode) if (srcstmt && integer_pow2p (gimple_assign_rhs2 (srcstmt))) { + tree temp; enum tree_code tcode = code == NE ? NE_EXPR : EQ_EXPR; + int bitnum = tree_log2 (gimple_assign_rhs2 (srcstmt)); + type = lang_hooks.types.type_for_mode (mode, unsignedp); - tree temp = fold_build2_loc (loc, BIT_AND_EXPR, TREE_TYPE (arg1), + temp = fold_single_bit_test (loc, tcode, gimple_assign_rhs1 (srcstmt), - gimple_assign_rhs2 (srcstmt)); - temp = fold_single_bit_test (loc, tcode, temp, arg1, type); + bitnum, type); if (temp) return expand_expr (temp, target, VOIDmode, EXPAND_NORMAL); } |