diff options
author | Richard Earnshaw <rearnsha@arm.com> | 2021-04-27 12:25:30 +0100 |
---|---|---|
committer | Richard Earnshaw <rearnsha@arm.com> | 2021-04-27 12:27:02 +0100 |
commit | 01d0bda8bdf3cd804e1e00915d432ad0cdc49399 (patch) | |
tree | f8d88c06e274b69106a5637ef6a33e998066d4a5 /gcc/expr.c | |
parent | 4cea5b8cb715e40e10174e6de405f26202fa3d6a (diff) | |
download | gcc-01d0bda8bdf3cd804e1e00915d432ad0cdc49399.zip gcc-01d0bda8bdf3cd804e1e00915d432ad0cdc49399.tar.gz gcc-01d0bda8bdf3cd804e1e00915d432ad0cdc49399.tar.bz2 |
arm: fix UB when compiling thumb2 with PIC [PR100236]
arm_compute_save_core_reg_mask contains UB in that the saved PIC
register number is used to create a bit mask. However, for some target
options this register is undefined and we end up with a shift of ~0.
On native compilations this is benign since the shift will still be
large enough to move the bit outside of the range of the mask, but if
cross compiling from a system that truncates out-of-range shifts to
zero (or worse, raises a trap for such values) we'll get potentially
wrong code (or a fault).
gcc:
PR target/100236
* config/arm/arm.c (THUMB2_WORK_REGS): Check PIC_OFFSET_TABLE_REGNUM
is valid before including it in the mask.
Diffstat (limited to 'gcc/expr.c')
0 files changed, 0 insertions, 0 deletions