aboutsummaryrefslogtreecommitdiff
path: root/gcc/expr.c
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2020-12-18 21:43:20 +0100
committerJakub Jelinek <jakub@redhat.com>2020-12-18 21:43:20 +0100
commit8b60459465252c7d47b58abf83fae2aa84915b03 (patch)
tree1c22419f9d6766808f503ef9c5ec741d6e7065e9 /gcc/expr.c
parentbfb37fa4dd49ee775ae90355464265a2f60c1067 (diff)
downloadgcc-8b60459465252c7d47b58abf83fae2aa84915b03.zip
gcc-8b60459465252c7d47b58abf83fae2aa84915b03.tar.gz
gcc-8b60459465252c7d47b58abf83fae2aa84915b03.tar.bz2
openmp: Don't optimize shared to firstprivate on task with depend clause
The attached testcase is miscompiled, because we optimize shared clauses to firstprivate when task body can't modify the variable even when the task has depend clause. That is wrong, because firstprivate means the variable will be copied immediately when the task is created, while with depend clause some other task might change it later before the dependencies are satisfied and the task should observe the value only after the change. 2020-12-18 Jakub Jelinek <jakub@redhat.com> * gimplify.c (struct gimplify_omp_ctx): Add has_depend member. (gimplify_scan_omp_clauses): Set it to true if OMP_CLAUSE_DEPEND appears on OMP_TASK. (gimplify_adjust_omp_clauses_1, gimplify_adjust_omp_clauses): Force GOVD_WRITTEN on shared variables if task construct has depend clause. * testsuite/libgomp.c/task-6.c: New test.
Diffstat (limited to 'gcc/expr.c')
0 files changed, 0 insertions, 0 deletions