diff options
author | Nicolas KÃnig <koenigni@student.ethz.ch> | 2020-10-18 13:37:30 +0200 |
---|---|---|
committer | Nicolas KÃnig <koenigni@student.ethz.ch> | 2020-10-18 13:44:33 +0200 |
commit | 7488585fc18a9466253617e251c0e0bdc168a3b1 (patch) | |
tree | 7d0d2faf6c03746ccdd2cf409022ae0d20866751 /gcc/data-streamer.c | |
parent | b96fdc7b84eb288dea0c3e99a212e6483007a35a (diff) | |
download | gcc-7488585fc18a9466253617e251c0e0bdc168a3b1.zip gcc-7488585fc18a9466253617e251c0e0bdc168a3b1.tar.gz gcc-7488585fc18a9466253617e251c0e0bdc168a3b1.tar.bz2 |
Implement comments from review.
This implements the comments from the review - the general prefix is now
cas (for coarray shared), and native has been renamed to shared generally.
Plus, there is a lot of cleanup such as removing dead code and
debug statements.
gcc/ChangeLog:
PR fortran/88076
* flag-types.h (enum gfc_fcoarray): Change GFC_FCOARRAY_NATIVE to
GFC_FCOARRAY_SHARED.
gcc/fortran/ChangeLog:
PR fortran/88076
* dump-parse-tree.c (show_symbol): Remove dumping of backend_decl.
* frontend-passes.c (gfc_run_passes): Generally rename "native" to
"shared" and "cas" instead of "nca".
(co_reduce_code): Initialize num. Generally rename "native" to
"shared" and "cas" instead of "nca".
* gfortran.h: Generally rename "native" to "shared".
* iresolve.c (gfc_resolve_co_collective): Use specific function
for library coarrays. Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_resolve_co_reduce): Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_resolve_co_broadcast): Generally rename "native" to "shared"
and "cas" instead of "nca".
* lang.opt: Generally rename "native" to "shared" and "cas"
instead of "nca".
* resolve.c (fixup_coarray_args): Rename to
(fixup_shared_coarray_args): Generally rename "native" to
"shared" and "cas" instead of "nca". Get rid of a variable.
(resolve_unknown_s): Fix whitespace.
(resolve_call): Generally rename "native" to "shared" and "cas"
instead of "nca".
(resolve_critical): Revert spurious change. Generally rename
"native" to "shared" and "cas" instead of "nca".
* trans-array.c (gfc_add_strides): Fix comment format.
(gfc_native_coarray_add_this_image_offset): Generally rename
"native" to "shared" and "cas" instead of "nca". Formatting
fixes.
(gfc_conv_ss_descriptor): Generally rename "native" to "shared"
and "cas" instead of "nca".
(build_array_ref): Remove empty line.
(gfc_conv_array_ref): Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_array_init_size): Special-case GFC_COARRAY_SHARED. Generally
rename "native" to "shared" and "cas" instead of "nca". Fix
formatting.
(gfc_allocate_native_coarray): Generally rename "native" to
"shared" and "cas" instead of "nca".
(gfc_array_allocate): Generally rename "native" to "shared" and
"cas" instead of "nca". Fix comment syntax.
(gfc_trans_dummy_array_bias): Generally rename "native" to
"shared" and "cas" instead of "nca".
(gfc_get_dataptr_offset): Generally rename "native" to "shared"
and "cas" instead of "nca". Fix comment style.
(gfc_conv_expr_descriptor): Remove code blocks guarded by #if 0 or #if 1.
(gfc_conv_array_parameter): Likewise.
(gfc_walk_array_ref): Likewise.
* trans-array.h (enum gfc_coarray_allocation_type): Change offset from 3 to 1.
* trans-decl.c: Generally rename "native" to "shared" and "cas"
instead of "nca" for tree declarations.
(gfc_build_qualified_array): Generally rename "native" to "shared"
and "cas" instead of "nca".
(gfc_build_dummy_array_decl): Generally rename "native" to "shared"
and "cas" instead of "nca".
(gfc_get_symbol_decl): Revert spurious change. Generally rename
"native" to "shared" and "cas" instead of "nca".
(gfc_build_builtin_function_decls): Generally rename "native" to
"shared" and "cas" instead of "nca".
(gfc_trans_native_coarray): Clarify comment. Generally rename
"native" to "shared" and "cas" instead of "nca".
(gfc_trans_deferred_vars): Generally rename "native" to "shared"
and "cas" instead of "nca".
(gfc_create_module_variable): Generally rename "native" to
"shared" and "cas" instead of "nca".
(generate_coarray_constructor_function): Generally rename "native"
to "shared" and "cas" instead of "nca".
(create_main_function): Generally rename "native" to "shared"
and "cas" instead of "nca".
* trans-expr.c (gfc_maybe_dereference_var): Remove branch where
condition is always false. Generally rename "native" to "shared"
and "cas" instead of "nca".
(gfc_conv_procedure_call): Remove code blocks guarded by #if 0.
Whitespace fix.
* trans-intrinsic.c (trans_this_image): Generally rename "native"
to "shared" and "cas" instead of "nca".
(trans_image_index): Remove unneeded TODO. Generally rename
"native" to "shared" and "cas" instead of "nca".
(trans_num_images): Generally rename "native" to "shared" and
"cas" instead of "nca".
(conv_intrinsic_cobound): Generally rename "native" to "shared"
and "cas" instead of "nca".
(trans_argument): Clarify comment explaining what the function does.
(conv_nca_reduce): Rename to...
(conv_cas_reduce): this. Add comment.
(conv_nca_broadcast): Rename to...
(conv_cas_broadcast): this.
(conv_nca_collective): Rename to...
(conv_cas_collective): this.
(conv_co_collective): Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_conv_intrinsic_subroutine): Generally rename "native" to
"shared" and "cas" instead of "nca".
* trans-stmt.c (gfc_trans_lock_unlock): Generally rename "native"
to "shared" and "cas" instead of "nca".
(gfc_trans_sync): Generally rename "native" to "shared" and "cas"
instead of "nca".
(gfc_trans_critical): Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_trans_deallocate): Generally rename "native" to "shared" and
"cas" instead of "nca".
* trans-types.c (gfc_is_nodesc_array): Generally rename "native"
to "shared" and "cas" instead of "nca".
(gfc_build_array_type): Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_get_nodesc_array_type): Generally rename "native" to "shared"
and "cas" instead of "nca".
(gfc_get_array_type_bounds): Generally rename "native" to "shared"
and "cas" instead of "nca".
* trans.c (gfc_trans_memory_barrier): Use sizeof instead of strlen,
replace comma by semicolon.
(gfc_build_array_ref): Generally rename "native" to "shared" and
"cas" instead of "nca".
(gfc_deallocate_with_status): Fix indentation. Generally rename
"native" to "shared" and "cas" instead of "nca".
* trans.h: Generally rename "native" to "shared" and "cas" instead
of "nca".
libgfortran/ChangeLog:
PR fortran/88076
* m4/nca-minmax-s.m4: Change "nca" prefix to "cas". Add comments.
* m4/nca_minmax.m4: Likewise.
* nca/README.native_coarrays: Update.
* nca/alloc.c (free_memory_with_id): Add FIXME.
* nca/coarraynative.c (nca_master): Rename to
(cas_master): Change logic for exiting images.
* nca/collective_subroutine.c (get_collsub_buf): Add comment.
(collsub_sync): Remove dead debug output.
(collsub_reduce_array): Silence -Wsign-compare warning.
(collsub_iface_init): Remove unused variable.
(collsub_broadcast_scalar): Remove debug code.
(collsub_broadcast_array): Remove unused variable.
(nca_co_broadcast): Remove commented-out function, plus its
(export_proto): prototype declaration.
* nca/collective_subroutine.h (finish_collective_subroutine): Add.
* nca/hashmap.c (num_entries): Silcence -Wsign-compare warning.
(hash): Formatting change (add empty lines).
(gen_mask): Likewise.
(hmiadd): Likewise.
(get_expected_offset): Likewise.
(hashmap_init): Likewise.
(scan_empty): Likewise. Remove unused argument.
(hashmap_get): Formatting change (add empty lines).
(hm_search_result_ptr): Likewise.
(hm_search_result_contains): Likewise.
(enlarge_hashmap_mem): Likewise.
(resize_hm): Likewise. Remove argument in call to scan_empty.
(hashmap_set): Remove dead debugging code. Silence -Wsign-compare
warning.
(hashmap_change_refcnt): Silence -Wsign-compare warning.
(hashmap_inc): Formatting change.
* nca/hashmap.h (Library): Add copyright notice.
* nca/libcoarraynative.h (DEBUG_NATIVE_COARRAY): #define as 0
(NUM_ADDR_BITS): Remove dead code.
(nca_master): Rename to
(cas_master): this.
* nca/shared_memory.c (shared_memory_get_mem_with_alignment):
Remove debug code.
* nca/shared_memory.h (SHARED_MEMORY_H): Move definition to start
of file.
* nca/sync.c (get_locked_table): Remove commented-out code.
(sync_iface_init): Remove debug code.
(sync_all): Remove debug code.
* nca/sync.h: Add space after #include.
* nca/util.c: Include assert.h. Add comment.
(next_power_of_two): Remove comment.
(pack_array_finish): Replace 0 by '\0' in memset.
(unpack_array_finish): Zero variable count.
* nca/wrapper.c (enum gfc_coarray_allocation_type): Enum starts at
one. Add comment about need to keep in sync with trans-array.h.
(nca_coarray_alloc): Rename to
(cas_coarray_alloc): this.
(nca_coarray_free): Rename to
(cas_coarray_free): this.
(nca_coarray_this_image): Rename to
(cas_coarray_this_image): this.
(nca_coarray_num_images): Rename to
(cas_coarray_num_images): this.
(nca_coarray_sync_all): Rename to
(cas_coarray_sync_all): this.
(nca_sync_images): Rename to
(cas_sync_images): this.
(nca_lock): Rename to
(cas_lock): this.
(nca_unlock): Rename to
(cas_unlock): this.
(nca_collsub_reduce_array): Rename to
(cas_collsub_reduce_array): this.
(nca_collsub_reduce_scalar): Rename to
(cas_collsub_reduce_scalar): this.
(nca_collsub_broadcast_array): Rename to
(cas_collsub_broadcast_array): this.
(nca_collsub_broadcast_scalar): Rename to
(cas_collsub_broadcast_scalar): this.
* nca/.tags: Delete.
* nca/collective_inline.h: Delete.
* generated/nca_minmax_i1.c: Regenerated.
* generated/nca_minmax_i16.c: Regenerated.
* generated/nca_minmax_i2.c: Regenerated.
* generated/nca_minmax_i4.c: Regenerated.
* generated/nca_minmax_i8.c: Regenerated.
* generated/nca_minmax_r10.c: Regenerated.
* generated/nca_minmax_r16.c: Regenerated.
* generated/nca_minmax_r4.c: Regenerated.
* generated/nca_minmax_r8.c: Regenerated.
* generated/nca_minmax_s1.c: Regenerated.
* generated/nca_minmax_s4.c: Regenerated.
Diffstat (limited to 'gcc/data-streamer.c')
0 files changed, 0 insertions, 0 deletions