c++: Add missing auto_diagnostic_groups

This patch goes through all .cc files in gcc/cp and adds in any
auto_diagnostic_groups that seem to be missing by looking for any
'inform' calls that aren't grouped with their respective error/warning.
Now with SARIF output support this seems to be a bit more important.

The patch isn't complete; I've tried to also track helper functions used
for diagnostics to group them, but some may have been missed.
Additionally there are a few functions that are definitely missing
groupings but I wasn't able to see an obvious way to add them without
potentially grouping together unrelated messages.

This list includes:

- lazy_load_{binding,pendings} "during load of {binding,pendings} for"
- cp_finish_decomp "in initialization of structured binding variable"
- require_deduced_type "using __builtin_source_location"
- convert_nontype_argument "in template argument for type %qT"
- coerce_template_params "so any instantiation with a non-empty parameter pack"
- tsubst_default_argument "when instantiating default argument"
- invalid_nontype_parm_type_p "invalid template non-type parameter"

gcc/cp/ChangeLog:

	* class.cc (add_method): Add missing auto_diagnostic_group.
	(handle_using_decl): Likewise.
	(maybe_warn_about_overly_private_class): Likewise.
	(check_field_decl): Likewise.
	(check_field_decls): Likewise.
	(resolve_address_of_overloaded_function): Likewise.
	(note_name_declared_in_class): Likewise.
	* constraint.cc (associate_classtype_constraints): Likewise.
	(diagnose_trait_expr): Clean up whitespace.
	* coroutines.cc (find_coro_traits_template_decl): Add missing
	auto_diagnostic_group.
	(coro_promise_type_found_p): Likewise.
	(coro_diagnose_throwing_fn): Likewise.
	* cvt.cc (build_expr_type_conversion): Likewise.
	* decl.cc (validate_constexpr_redeclaration): Likewise.
	(duplicate_function_template_decls): Likewise.
	(duplicate_decls): Likewise.
	(lookup_label_1): Likewise.
	(check_previous_goto_1): Likewise.
	(check_goto_1): Likewise.
	(make_typename_type): Likewise.
	(make_unbound_class_template): Likewise.
	(check_tag_decl): Likewise.
	(start_decl): Likewise.
	(maybe_commonize_var): Likewise.
	(check_for_uninitialized_const_var): Likewise.
	(reshape_init_class): Likewise.
	(check_initializer): Likewise.
	(cp_finish_decl): Likewise.
	(find_decomp_class_base): Likewise.
	(cp_finish_decomp): Likewise.
	(expand_static_init): Likewise.
	(grokfndecl): Likewise.
	(grokdeclarator): Likewise.
	(check_elaborated_type_specifier): Likewise.
	(lookup_and_check_tag): Likewise.
	(xref_tag): Likewise.
	(cxx_simulate_enum_decl): Likewise.
	(finish_function): Likewise.
	* decl2.cc (check_classfn): Likewise.
	(record_mangling): Likewise.
	(mark_used): Likewise.
	* error.cc (qualified_name_lookup_error): Likewise.
	* except.cc (build_throw): Likewise.
	* init.cc (get_nsdmi): Likewise.
	(diagnose_uninitialized_cst_or_ref_member_1): Likewise.
	(warn_placement_new_too_small): Likewise.
	(build_new_1): Likewise.
	(build_vec_delete_1): Likewise.
	(build_delete): Likewise.
	* lambda.cc (add_capture): Likewise.
	(add_default_capture): Likewise.
	* lex.cc (unqualified_fn_lookup_error): Likewise.
	* method.cc (synthesize_method): Likewise.
	(defaulted_late_check): Likewise.
	* module.cc (trees_in::is_matching_decl): Likewise.
	(trees_in::read_enum_def): Likewise.
	(module_state::check_not_purview): Likewise.
	(module_state::deferred_macro): Likewise.
	(module_state::read_config): Likewise.
	(module_state::check_read): Likewise.
	(declare_module): Likewise.
	(init_modules): Likewise.
	* name-lookup.cc (diagnose_name_conflict): Likewise.
	(lookup_using_decl): Likewise.
	(set_decl_namespace): Likewise.
	(finish_using_directive): Likewise.
	(push_namespace): Likewise.
	(add_imported_namespace): Likewise.
	* parser.cc (cp_parser_check_for_definition_in_return_type): Likewise.
	(cp_parser_userdef_numeric_literal): Likewise.
	(cp_parser_nested_name_specifier_opt): Likewise.
	(cp_parser_new_expression): Likewise.
	(cp_parser_binary_expression): Likewise.
	(cp_parser_lambda_introducer): Likewise.
	(cp_parser_module_declaration): Likewise.
	(cp_parser_import_declaration): Likewise, removing gotos to
	support this.
	(cp_parser_declaration): Add missing auto_diagnostic_group.
	(cp_parser_decl_specifier_seq): Likewise.
	(cp_parser_template_id): Likewise.
	(cp_parser_template_name): Likewise.
	(cp_parser_explicit_specialization): Likewise.
	(cp_parser_placeholder_type_specifier): Likewise.
	(cp_parser_elaborated_type_specifier): Likewise.
	(cp_parser_enum_specifier): Likewise.
	(cp_parser_asm_definition): Likewise.
	(cp_parser_init_declarator): Likewise.
	(cp_parser_direct_declarator): Likewise.
	(cp_parser_class_head): Likewise.
	(cp_parser_member_declaration): Likewise.
	(cp_parser_lookup_name): Likewise.
	(cp_parser_explicit_template_declaration): Likewise.
	(cp_parser_check_class_key): Likewise.
	* pt.cc (maybe_process_partial_specialization): Likewise.
	(determine_specialization): Likewise.
	(check_for_bare_parameter_packs): Likewise.
	(check_template_shadow): Likewise.
	(process_partial_specialization): Likewise.
	(push_template_decl): Likewise.
	(redeclare_class_template): Likewise.
	(convert_nontype_argument_function): Likewise.
	(check_valid_ptrmem_cst_expr): Likewise.
	(convert_nontype_argument): Likewise.
	(convert_template_argument): Likewise.
	(coerce_template_parms): Likewise.
	(tsubst_qualified_id): Likewise.
	(tsubst_expr): Likewise.
	(most_specialized_partial_spec): Likewise.
	(do_class_deduction): Likewise.
	(do_auto_deduction): Likewise.
	* search.cc (lookup_member): Likewise.
	* semantics.cc (finish_non_static_data_member): Likewise.
	(process_outer_var_ref): Likewise.
	(finish_id_expression_1): Likewise.
	(finish_offsetof): Likewise.
	(omp_reduction_lookup): Likewise.
	(finish_omp_clauses): Likewise.
	* tree.cc (check_abi_tag_redeclaration): Likewise.
	(check_abi_tag_args): Likewise.
	* typeck.cc (invalid_nonstatic_memfn_p): Likewise.
	(complain_about_unrecognized_member): Likewise.
	(finish_class_member_access_expr): Likewise.
	(error_args_num): Likewise.
	(warn_for_null_address): Likewise.
	(cp_build_binary_op): Likewise.
	(build_x_unary_op): Likewise.
	(cp_build_unary_op): Likewise.
	(build_static_cast): Likewise.
	(cp_build_modify_expr): Likewise.
	(get_delta_difference): Likewise.
	(convert_for_assignment): Widen scope of auto_diagnostic_group.
	(check_return_expr): Add missing auto_diagnostic_group.
	* typeck2.cc (cxx_incomplete_type_diagnostic): Likewise.

Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
Reviewed-by: Marek Polacek <polacek@redhat.com>

1 files changed, 3 insertions, 0 deletions

diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc
index 31ecbb1..c3a38de 100644
--- a/gcc/cp/tree.cc
+++ b/gcc/cp/tree.cc
@@ -5223,6 +5223,7 @@ check_abi_tag_redeclaration (const_tree decl, const_tree old, const_tree new_)
   if (new_ && TREE_CODE (TREE_VALUE (new_)) == TREE_LIST)
     new_ = TREE_VALUE (new_);
   bool err = false;
+  auto_diagnostic_group d;
   for (const_tree t = new_; t; t = TREE_CHAIN (t))
     {
       tree str = TREE_VALUE (t);
@@ -5276,6 +5277,7 @@ check_abi_tag_args (tree args, tree name)
 	    {
 	      if (!ISALPHA (c) && c != '_')
 		{
+		  auto_diagnostic_group d;
 		  error ("arguments to the %qE attribute must contain valid "
 			 "identifiers", name);
 		  inform (input_location, "%<%c%> is not a valid first "
@@ -5289,6 +5291,7 @@ check_abi_tag_args (tree args, tree name)
 	    {
 	      if (!ISALNUM (c) && c != '_')
 		{
+		  auto_diagnostic_group d;
 		  error ("arguments to the %qE attribute must contain valid "
 			 "identifiers", name);
 		  inform (input_location, "%<%c%> is not a valid character "