diff options
| author | Jason Merrill <jason@redhat.com> | 2024-05-22 18:41:27 -0400 |
|---|---|---|
| committer | Jason Merrill <jason@redhat.com> | 2024-05-23 16:23:39 -0400 |
| commit | ed63cd2aa5b114565fe5499c3a6bf8da5e8e48ba (patch) | |
| tree | 06272b6b470f3791b6a43b1a09e254e5609a141a /gcc/cp/tree.cc | |
| parent | 0b3b6a8df77b0ae15078402ea5fb933d6fccd585 (diff) | |
| download | gcc-ed63cd2aa5b114565fe5499c3a6bf8da5e8e48ba.zip gcc-ed63cd2aa5b114565fe5499c3a6bf8da5e8e48ba.tar.gz gcc-ed63cd2aa5b114565fe5499c3a6bf8da5e8e48ba.tar.bz2 | |
c++: deleting array temporary [PR115187]
Decaying the array temporary to a pointer and then deleting that crashes in
verify_gimple_stmt, because the TARGET_EXPR is first evaluated inside the
TRY_FINALLY_EXPR, but the cleanup point is outside. Fixed by using
get_target_expr instead of save_expr.
I also adjust the stabilize_expr comment to prevent me from again thinking
it's a suitable replacement.
PR c++/115187
gcc/cp/ChangeLog:
* init.cc (build_delete): Use get_target_expr instead of save_expr.
* tree.cc (stabilize_expr): Update comment.
gcc/testsuite/ChangeLog:
* g++.dg/cpp1z/array-prvalue3.C: New test.
Diffstat (limited to 'gcc/cp/tree.cc')
| -rw-r--r-- | gcc/cp/tree.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc index 4d87661..0485a61 100644 --- a/gcc/cp/tree.cc +++ b/gcc/cp/tree.cc @@ -5924,7 +5924,11 @@ decl_storage_duration (tree decl) *INITP) an expression that will perform the pre-evaluation. The value returned by this function is a side-effect free expression equivalent to the pre-evaluated expression. Callers must ensure - that *INITP is evaluated before EXP. */ + that *INITP is evaluated before EXP. + + Note that if EXPR is a glvalue, the return value is a glvalue denoting the + same address; this function does not guard against modification of the + stored value like save_expr or get_target_expr do. */ tree stabilize_expr (tree exp, tree* initp) |