diff options
author | Martin Jambor <mjambor@suse.cz> | 2020-04-16 19:21:02 +0200 |
---|---|---|
committer | Martin Jambor <mjambor@suse.cz> | 2020-04-16 19:21:02 +0200 |
commit | 7123347c8b44571811c4b58506b06fb09969bccb (patch) | |
tree | ddf5d23a57ce231aef99ac668163fa8a8baddcde /gcc/cgraphunit.c | |
parent | 26bebf576ddcdcfb596f07e8c2896f17c48516e7 (diff) | |
download | gcc-7123347c8b44571811c4b58506b06fb09969bccb.zip gcc-7123347c8b44571811c4b58506b06fb09969bccb.tar.gz gcc-7123347c8b44571811c4b58506b06fb09969bccb.tar.bz2 |
ipa: Make call redirection detect already adjusted calls (PR 93621)
PR 93621 testcase makes redirect_call_stmt_to_callee wrongly assume
that a call statement needs redirecting but then rightly fails an
assert ensuring the call statement parameters have not already been
adjusted because they were already created adjusted as part of thunk
expansion.
The test fails because the decl in the call call statement is
different than the decl of the callee, because the latter was created
in save_inline_function_body. This patch adds a way to link these two
and detect the situation in redirect_call_stmt_to_callee.
2020-04-16 Martin Jambor <mjambor@suse.cz>
PR ipa/93621
* ipa-inline.h (ipa_saved_clone_sources): Declare.
* ipa-inline-transform.c (ipa_saved_clone_sources): New variable.
(save_inline_function_body): Link the new body holder with the
previous one.
* cgraph.c: Include ipa-inline.h.
(cgraph_edge::redirect_call_stmt_to_callee): Try to find the decl from
the statement in ipa_saved_clone_sources.
* cgraphunit.c: Include ipa-inline.h.
(expand_all_functions): Free ipa_saved_clone_sources.
testsuite/
* g++.dg/ipa/pr93621.C: New test.
Diffstat (limited to 'gcc/cgraphunit.c')
-rw-r--r-- | gcc/cgraphunit.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c index 0e255f2..a1ace95 100644 --- a/gcc/cgraphunit.c +++ b/gcc/cgraphunit.c @@ -205,6 +205,7 @@ along with GCC; see the file COPYING3. If not see #include "lto-section-names.h" #include "stringpool.h" #include "attribs.h" +#include "ipa-inline.h" /* Queue of cgraph nodes scheduled to be added into cgraph. This is a secondary queue used during optimization to accommodate passes that @@ -2481,7 +2482,8 @@ expand_all_functions (void) symtab->process_new_functions (); free_gimplify_stack (); - + delete ipa_saved_clone_sources; + ipa_saved_clone_sources = NULL; free (order); } |