diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2021-02-18 22:17:52 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2021-02-18 22:17:52 +0100 |
| commit | d82f829905cfe6cb47d073825f680900274ce764 (patch) | |
| tree | ece022c89d1708ed44180958ed3719accb71ce16 /gcc/c | |
| parent | 1021222ee4d291ccb4f49cd0ae3393c83d8ff5d0 (diff) | |
| download | gcc-d82f829905cfe6cb47d073825f680900274ce764.zip gcc-d82f829905cfe6cb47d073825f680900274ce764.tar.gz gcc-d82f829905cfe6cb47d073825f680900274ce764.tar.bz2 | |
c: Fix ICE with -fexcess-precision=standard [PR99136]
The following testcase ICEs on i686-linux, because c_finish_return wraps
c_fully_folded retval back into EXCESS_PRECISION_EXPR, but when the function
return type is void, we don't call convert_for_assignment on it that would
then be fully folded again, but just put the retval into RETURN_EXPR's
operand, so nothing removes it anymore and during gimplification we
ICE as EXCESS_PRECISION_EXPR is not handled.
This patch fixes it by not adding that EXCESS_PRECISION_EXPR in functions
returning void, the return value is ignored and all we need is evaluate any
side-effects of the expression.
2021-02-18 Jakub Jelinek <jakub@redhat.com>
PR c/99136
* c-typeck.c (c_finish_return): Don't wrap retval into
EXCESS_PRECISION_EXPR in functions that return void.
* gcc.dg/pr99136.c: New test.
Diffstat (limited to 'gcc/c')
| -rw-r--r-- | gcc/c/c-typeck.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c index 725dc51..4e6d369 100644 --- a/gcc/c/c-typeck.c +++ b/gcc/c/c-typeck.c @@ -10740,7 +10740,9 @@ c_finish_return (location_t loc, tree retval, tree origtype) retval = TREE_OPERAND (retval, 0); } retval = c_fully_fold (retval, false, NULL); - if (semantic_type) + if (semantic_type + && valtype != NULL_TREE + && TREE_CODE (valtype) != VOID_TYPE) retval = build1 (EXCESS_PRECISION_EXPR, semantic_type, retval); } |