aboutsummaryrefslogtreecommitdiff
path: root/gcc/c
diff options
context:
space:
mode:
authorRichard Sandiford <richard.sandiford@arm.com>2016-05-09 15:30:32 +0000
committerRichard Sandiford <rsandifo@gcc.gnu.org>2016-05-09 15:30:32 +0000
commite3abc83ebaea2312510ace3da69436393e73046c (patch)
tree17ca09172235f42f9b155a4381183327145e72ef /gcc/c
parentb9a28869b9314fb06386f6fd2c52d42644d6618d (diff)
downloadgcc-e3abc83ebaea2312510ace3da69436393e73046c.zip
gcc-e3abc83ebaea2312510ace3da69436393e73046c.tar.gz
gcc-e3abc83ebaea2312510ace3da69436393e73046c.tar.bz2
Fix handling of negative bitpos in expand_debug_expr
expand_debug_expr handled negative bit positions using: else if (bitpos < 0) { HOST_WIDE_INT units = (-bitpos + BITS_PER_UNIT - 1) / BITS_PER_UNIT; op0 = adjust_address_nv (op0, mode1, units); bitpos += units * BITS_PER_UNIT; } Here "units" is the negative of the (negative) byte offset, so I think we should be offsetting OP0 by -units instead. E.g. a bitpos of -17 would give units==3, so this code would move OP0 up by 3 bytes and set bitpos to 7, giving a total bitpos of 31. Just noticed by inspection. An assert triggered for: gcc.target/i386/mpx/bitfields-1-lbv.c gcc.target/i386/mpx/field-addr-7-lbv.c gcc.target/i386/mpx/reference-3-lbv.cpp gcc.target/i386/mpx/reference-4-lbv.cpp at -m32 but otherwise this case doesn't seem to trigger during a bootstrap and regtest. Tested on x86_64-linux-gnu. gcc/ * cfgexpand.c (expand_debug_expr): Fix address offset for negative bitpos. From-SVN: r236041
Diffstat (limited to 'gcc/c')
0 files changed, 0 insertions, 0 deletions