diff options
| author | Ollie Wild <aaw@google.com> | 2012-04-27 14:29:32 +0000 |
|---|---|---|
| committer | Ollie Wild <aaw@gcc.gnu.org> | 2012-04-27 14:29:32 +0000 |
| commit | 7f5f5f98c5c21e263884362a248e5891e98ac6bc (patch) | |
| tree | 4fb8c09994e5867bbbb9d8cd9a507399b19ac47e /gcc/c-family | |
| parent | 11ec770e46f664966c53b6af90a2849c1eb4dbd1 (diff) | |
| download | gcc-7f5f5f98c5c21e263884362a248e5891e98ac6bc.zip gcc-7f5f5f98c5c21e263884362a248e5891e98ac6bc.tar.gz gcc-7f5f5f98c5c21e263884362a248e5891e98ac6bc.tar.bz2 | |
Add new option, -Wliteral-suffix.
This option, which is enabled by default, causes the preprocessor to warn
when a string or character literal is followed by a ud-suffix which does
not begin with an underscore. According to [lex.ext]p10, this is
ill-formed.
Also modifies the preprocessor to treat such ill-formed suffixes as separate
preprocessing tokens. This is consistent with the Clang front end (see
http://llvm.org/viewvc/llvm-project?view=rev&revision=152287), and enables
backwards compatibility with code that uses formatting macros from
<inttypes.h>, as in the following code block:
int main() {
int64_t i64 = 123;
printf("My int64: %"PRId64"\n", i64);
}
Google ref b/6377711.
2012-04-27 Ollie Wild <aaw@google.com>
PR c++/52538
* gcc/c-family/c-common.c: Add CPP_W_LITERAL_SUFFIX mapping.
* gcc/c-family/c-opts.c (c_common_handle_option): Handle
OPT_Wliteral_suffix.
* gcc/c-family/c.opt: Add Wliteral-suffix.
* gcc/doc/invoke.texi (Wliteral-suffix): Document new option.
* gcc/testsuite/g++.dg/cpp0x/Wliteral-suffix.c: New test.
* libcpp/include/cpplib.h (struct cpp_options): Add new field,
warn_literal_suffix.
(CPP_W_LITERAL_SUFFIX): New enum.
* libcpp/init.c (cpp_create_reader): Default initialization of
warn_literal_suffix.
* libcpp/lex.c (lex_raw_string): Treat user-defined literals which
don't begin with '_' as separate tokens and produce a warning.
(lex_string): Ditto.
From-SVN: r186909
Diffstat (limited to 'gcc/c-family')
| -rw-r--r-- | gcc/c-family/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/c-family/c-common.c | 1 | ||||
| -rw-r--r-- | gcc/c-family/c-opts.c | 4 | ||||
| -rw-r--r-- | gcc/c-family/c.opt | 4 |
4 files changed, 15 insertions, 0 deletions
diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog index fb89531..2082ff6 100644 --- a/gcc/c-family/ChangeLog +++ b/gcc/c-family/ChangeLog @@ -1,3 +1,9 @@ +2012-04-27 Ollie Wild <aaw@google.com> + + * c-common.c: Add CPP_W_LITERAL_SUFFIX mapping. + * c-opts.c (c_common_handle_option): Handle OPT_Wliteral_suffix. + * c.opt: Add Wliteral-suffix. + 2012-04-22 Manuel López-Ibáñez <manu@gcc.gnu.org> PR c/44774 diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index 4eacd19..bf5b034 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -8820,6 +8820,7 @@ static const struct reason_option_codes_t option_codes[] = { {CPP_W_NORMALIZE, OPT_Wnormalized_}, {CPP_W_INVALID_PCH, OPT_Winvalid_pch}, {CPP_W_WARNING_DIRECTIVE, OPT_Wcpp}, + {CPP_W_LITERAL_SUFFIX, OPT_Wliteral_suffix}, {CPP_W_NONE, 0} }; diff --git a/gcc/c-family/c-opts.c b/gcc/c-family/c-opts.c index 17e1958..2510747 100644 --- a/gcc/c-family/c-opts.c +++ b/gcc/c-family/c-opts.c @@ -476,6 +476,10 @@ c_common_handle_option (size_t scode, const char *arg, int value, cpp_opts->warn_invalid_pch = value; break; + case OPT_Wliteral_suffix: + cpp_opts->warn_literal_suffix = value; + break; + case OPT_Wlong_long: cpp_opts->cpp_warn_long_long = value; break; diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index d8c944d..db8ca81 100644 --- a/gcc/c-family/c.opt +++ b/gcc/c-family/c.opt @@ -449,6 +449,10 @@ Wjump-misses-init C ObjC Var(warn_jump_misses_init) Init(-1) Warning Warn when a jump misses a variable initialization +Wliteral-suffix +C++ ObjC++ Warning +Warn when a string or character literal is followed by a ud-suffix which does not begin with an underscore. + Wlogical-op C ObjC C++ ObjC++ Var(warn_logical_op) Init(0) Warning Warn when a logical operator is suspiciously always evaluating to true or false |