diff options
| author | Manuel López-Ibáñez <manu@gcc.gnu.org> | 2008-10-24 10:09:06 +0000 |
|---|---|---|
| committer | Manuel López-Ibáñez <manu@gcc.gnu.org> | 2008-10-24 10:09:06 +0000 |
| commit | 100d537d7a7b5c0ef775d568ce3eefffa72f2c41 (patch) | |
| tree | 700b750bc17a07e7749365330c49e0f595aaa435 /gcc/c-common.h | |
| parent | 950d63e12fd0a69731a4c1ae313135f2d47d30a9 (diff) | |
| download | gcc-100d537d7a7b5c0ef775d568ce3eefffa72f2c41.zip gcc-100d537d7a7b5c0ef775d568ce3eefffa72f2c41.tar.gz gcc-100d537d7a7b5c0ef775d568ce3eefffa72f2c41.tar.bz2 | |
re PR c/7543 (no warning for always-false "if (!a & 0x4)" bitwise and on boolean value)
2008-10-24 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR c/7543
* value-prof.c (gimple_stringop_fixed_value): Use parentheses
around bit operation.
* profile.c (is_edge_inconsistent): Likewise.
* fold-const.c (truth_value_p): Move from here...
* tree.h (truth_value_p): ... to here.
* c-tree.h (c_expr): Update description of original_code.
* c-typeck.c (parser_build_unary_op): Set original_code.
(parser_build_binary_op): Update call to warn_about_parentheses.
* c-common.c (warn_about_parentheses): Take two additional
arguments of the operands. Use a switch. Quote operators
appropriately. Define macro APPEARS_TO_BE_BOOLEAN_EXPR_P.
Add warning about !x | y and !x & y.
* c-common.h (warn_about_parentheses): Update declaration.
cp/
* typeck.c (build_x_binary_op): Update call to
warn_about_parentheses.
* parser.c (cp_parser_binary_expression): Add note about passing
the correct code for unary expressions.
testsuite/
* gcc.dg/Wparentheses-11.c: New.
* g++.dg/warn/Wparentheses-25.C: New. XFAILED.
From-SVN: r141340
Diffstat (limited to 'gcc/c-common.h')
| -rw-r--r-- | gcc/c-common.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gcc/c-common.h b/gcc/c-common.h index cd4eb31..be38a60 100644 --- a/gcc/c-common.h +++ b/gcc/c-common.h @@ -912,8 +912,9 @@ extern int complete_array_type (tree *, tree, bool); extern tree builtin_type_for_size (int, bool); extern void warn_array_subscript_with_type_char (tree); -extern void warn_about_parentheses (enum tree_code, enum tree_code, - enum tree_code); +extern void warn_about_parentheses (enum tree_code, + enum tree_code, tree, + enum tree_code, tree); extern void warn_for_unused_label (tree label); extern void warn_for_div_by_zero (location_t, tree divisor); extern void warn_for_sign_compare (location_t, |