diff options
author | Segher Boessenkool <segher@kernel.crashing.org> | 2017-06-23 19:37:27 +0200 |
---|---|---|
committer | Segher Boessenkool <segher@gcc.gnu.org> | 2017-06-23 19:37:27 +0200 |
commit | 08c273bb9ca995bc8c8f58a3cbdb2be6a47765bd (patch) | |
tree | 89c7f9311baba6c0a9a0a452d30f482c63850b2a /gcc/builtins.c | |
parent | eded3fe59237591c17259f1b6df9174b25643673 (diff) | |
download | gcc-08c273bb9ca995bc8c8f58a3cbdb2be6a47765bd.zip gcc-08c273bb9ca995bc8c8f58a3cbdb2be6a47765bd.tar.gz gcc-08c273bb9ca995bc8c8f58a3cbdb2be6a47765bd.tar.bz2 |
Fix expand_builtin_atomic_fetch_op for pre-op (PR80902)
__atomic_add_fetch adds a value to some memory, and returns the result.
If there is no direct support for this, expand_builtin_atomic_fetch_op
is asked to implement this as __atomic_fetch_add (which returns the
original value of the mem), followed by the addition. Now, the
__atomic_add_fetch could have been a tail call, but we shouldn't
perform the __atomic_fetch_add as a tail call: following code would
not be executed, and in fact thrown away because there is a barrier
after tail calls.
This fixes it.
PR middle-end/80902
* builtins.c (expand_builtin_atomic_fetch_op): If emitting code after
a call, force the call to not be a tail call.
From-SVN: r249603
Diffstat (limited to 'gcc/builtins.c')
-rw-r--r-- | gcc/builtins.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/gcc/builtins.c b/gcc/builtins.c index ce657bf..7e829ef 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -6079,6 +6079,12 @@ expand_builtin_atomic_fetch_op (machine_mode mode, tree exp, rtx target, gcc_assert (TREE_OPERAND (addr, 0) == fndecl); TREE_OPERAND (addr, 0) = builtin_decl_explicit (ext_call); + /* If we will emit code after the call, the call can not be a tail call. + If it is emitted as a tail call, a barrier is emitted after it, and + then all trailing code is removed. */ + if (!ignore) + CALL_EXPR_TAILCALL (exp) = 0; + /* Expand the call here so we can emit trailing code. */ ret = expand_call (exp, target, ignore); |