diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2023-03-22 08:40:34 -0400 |
|---|---|---|
| committer | David Malcolm <dmalcolm@redhat.com> | 2023-03-22 08:40:34 -0400 |
| commit | 0c652ebbf79bd168766097f3ac4c1b3b79d68a43 (patch) | |
| tree | 820aef7492def9c7de3fc8740cb0606222aa4e39 /gcc/analyzer/sm-malloc.cc | |
| parent | 1bde3acee77c171117dfb988998daa8197c73b34 (diff) | |
| download | gcc-0c652ebbf79bd168766097f3ac4c1b3b79d68a43.zip gcc-0c652ebbf79bd168766097f3ac4c1b3b79d68a43.tar.gz gcc-0c652ebbf79bd168766097f3ac4c1b3b79d68a43.tar.bz2 | |
analyzer: fix false +ves from -Wanalyzer-deref-before-check due to inlining [PR109239]
The patch has this effect on my integration tests of -fanalyzer:
Comparison:
GOOD: 129 (17.70% -> 17.92%)
BAD: 600 -> 591 (-9)
which is purely due to improvements to -Wanalyzer-deref-before-check
on the Linux kernel:
-Wanalyzer-deref-before-check:
GOOD: 1 (4.55% -> 7.69%)
BAD: 21 -> 12 (-9)
Known false positives: 16 -> 10 (-6)
linux-5.10.162: 7 -> 1 (-6)
Suspected false positives: 3 -> 0 (-3)
linux-5.10.162: 3 -> 0 (-3)
gcc/analyzer/ChangeLog:
PR analyzer/109239
* program-point.cc: Include "analyzer/inlining-iterator.h".
(program_point::effectively_intraprocedural_p): New function.
* program-point.h (program_point::effectively_intraprocedural_p):
New decl.
* sm-malloc.cc (deref_before_check::emit): Use it when rejecting
interprocedural cases, so that we reject interprocedural cases
that have become intraprocedural due to inlining.
gcc/testsuite/ChangeLog:
PR analyzer/109239
* gcc.dg/analyzer/deref-before-check-pr109239-linux-bus.c: New test.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
Diffstat (limited to 'gcc/analyzer/sm-malloc.cc')
| -rw-r--r-- | gcc/analyzer/sm-malloc.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/gcc/analyzer/sm-malloc.cc b/gcc/analyzer/sm-malloc.cc index 16883d3..7470137 100644 --- a/gcc/analyzer/sm-malloc.cc +++ b/gcc/analyzer/sm-malloc.cc @@ -1520,10 +1520,11 @@ public: if (!m_check_enode) return false; /* Only emit the warning for intraprocedural cases. */ - if (m_deref_enode->get_function () != m_check_enode->get_function ()) - return false; - if (&m_deref_enode->get_point ().get_call_string () - != &m_check_enode->get_point ().get_call_string ()) + const program_point &deref_point = m_deref_enode->get_point (); + const program_point &check_point = m_check_enode->get_point (); + + if (!program_point::effectively_intraprocedural_p (deref_point, + check_point)) return false; /* Reject the warning if the check occurs within a macro defintion. |