diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2021-04-24 19:49:31 -0400 |
|---|---|---|
| committer | David Malcolm <dmalcolm@redhat.com> | 2021-04-24 19:49:31 -0400 |
| commit | 61bfff562e3b6091d5a0a412a7d496bd523868a8 (patch) | |
| tree | 7a0ea8554cc234243438422f4f941458013d4312 /gcc/analyzer/sm-malloc.cc | |
| parent | d0e7833b94953ba6b4a915150666969ad9fc66af (diff) | |
| download | gcc-61bfff562e3b6091d5a0a412a7d496bd523868a8.zip gcc-61bfff562e3b6091d5a0a412a7d496bd523868a8.tar.gz gcc-61bfff562e3b6091d5a0a412a7d496bd523868a8.tar.bz2 | |
analyzer: fix ICE on NULL change.m_expr [PR100244]
PR analyzer/100244 reports an ICE on a -Wanalyzer-free-of-non-heap
due to a case where free_of_non_heap::describe_state_change can be
passed a NULL change.m_expr for a suitably complicated symbolic value.
Bulletproof it by checking for change.m_expr being NULL before
dereferencing it.
gcc/analyzer/ChangeLog:
PR analyzer/100244
* sm-malloc.cc (free_of_non_heap::describe_state_change):
Bulletproof against change.m_expr being NULL.
gcc/testsuite/ChangeLog:
PR analyzer/100244
* g++.dg/analyzer/pr100244.C: New test.
Diffstat (limited to 'gcc/analyzer/sm-malloc.cc')
| -rw-r--r-- | gcc/analyzer/sm-malloc.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gcc/analyzer/sm-malloc.cc b/gcc/analyzer/sm-malloc.cc index 1d5b860..f02b73a 100644 --- a/gcc/analyzer/sm-malloc.cc +++ b/gcc/analyzer/sm-malloc.cc @@ -1303,7 +1303,7 @@ public: { /* Attempt to reconstruct what kind of pointer it is. (It seems neater for this to be a part of the state, though). */ - if (TREE_CODE (change.m_expr) == SSA_NAME) + if (change.m_expr && TREE_CODE (change.m_expr) == SSA_NAME) { gimple *def_stmt = SSA_NAME_DEF_STMT (change.m_expr); if (gcall *call = dyn_cast <gcall *> (def_stmt)) |