diff options
| author | Justin Squirek <squirek@adacore.com> | 2019-09-18 08:33:23 +0000 |
|---|---|---|
| committer | Pierre-Marie de Rodat <pmderodat@gcc.gnu.org> | 2019-09-18 08:33:23 +0000 |
| commit | 483af72e4bf2499fdbbf6b6e061318eaa9ba2b2d (patch) | |
| tree | 8ff6a4e9492ec071e4d3e391a8c978ce26d929b3 /gcc/ada/sem_ch8.adb | |
| parent | 1b2f53bb9ad9c903a126bbe5d6c5672550a54c13 (diff) | |
| download | gcc-483af72e4bf2499fdbbf6b6e061318eaa9ba2b2d.zip gcc-483af72e4bf2499fdbbf6b6e061318eaa9ba2b2d.tar.gz gcc-483af72e4bf2499fdbbf6b6e061318eaa9ba2b2d.tar.bz2 | |
[Ada] Spurious ineffective use_clause warning
This patch fixes an issue whereby expansion of post conditions may lead
to spurious ineffective use_clause warnings when a use type clause is
present in a package specification and a use package clause exists in
the package body on the package containing said type.
2019-09-18 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_ch8.adb (Use_One_Type): Add guard to prevent warning on a
reundant use package clause where there is no previous
use_clause in the chain.
gcc/testsuite/
* gnat.dg/warn30.adb, gnat.dg/warn30.ads: New testcase.
From-SVN: r275861
Diffstat (limited to 'gcc/ada/sem_ch8.adb')
| -rw-r--r-- | gcc/ada/sem_ch8.adb | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/gcc/ada/sem_ch8.adb b/gcc/ada/sem_ch8.adb index a7918da..5d03f835 100644 --- a/gcc/ada/sem_ch8.adb +++ b/gcc/ada/sem_ch8.adb @@ -10337,11 +10337,18 @@ package body Sem_Ch8 is -- The package where T is declared is already used elsif In_Use (Scope (T)) then - Error_Msg_Sloc := - Sloc (Find_Most_Prev (Current_Use_Clause (Scope (T)))); - Error_Msg_NE -- CODEFIX - ("& is already use-visible through package use clause #??", - Id, T); + -- Due to expansion of contracts we could be attempting to issue + -- a spurious warning - so verify there is a previous use clause. + + if Current_Use_Clause (Scope (T)) /= + Find_Most_Prev (Current_Use_Clause (Scope (T))) + then + Error_Msg_Sloc := + Sloc (Find_Most_Prev (Current_Use_Clause (Scope (T)))); + Error_Msg_NE -- CODEFIX + ("& is already use-visible through package use clause #??", + Id, T); + end if; -- The current scope is the package where T is declared |