diff options
author | Marek Polacek <polacek@redhat.com> | 2020-12-03 18:35:00 -0500 |
---|---|---|
committer | Marek Polacek <polacek@redhat.com> | 2020-12-07 11:54:30 -0500 |
commit | 1cac89da2cb1f2a7c2d93f7f325484c2d1619ca8 (patch) | |
tree | d83a2760dce18de383aec51214737555dd9ad222 /gcc/ada/gcc-interface/utils.c | |
parent | ffb268ffcf9f21e2981a71887324eb0aec245eea (diff) | |
download | gcc-1cac89da2cb1f2a7c2d93f7f325484c2d1619ca8.zip gcc-1cac89da2cb1f2a7c2d93f7f325484c2d1619ca8.tar.gz gcc-1cac89da2cb1f2a7c2d93f7f325484c2d1619ca8.tar.bz2 |
c-family: Fix hang with -Wsequence-point [PR98126]
verify_sequence_points uses verify_tree to recursively walk the
subexpressions of an expression, and while recursing, it also
keeps lists of expressions found after/before a sequence point.
For a large expression, the list can grow significantly. And
merge_tlist is at least N(n^2): for a list of length n it will
iterate n(n -1) times, and call candidate_equal_p each time, and
that can recurse further. warn_for_collision also has to go
through the whole list. With a large-enough expression, the
compilation can easily get stuck here for 24 hours.
This patch is a simple kludge: if we see that the expression is
overly complex, don't even try.
gcc/c-family/ChangeLog:
PR c++/98126
* c-common.c (verify_tree_lim_r): New function.
(verify_sequence_points): Use it. Use nullptr instead of 0.
gcc/testsuite/ChangeLog:
PR c++/98126
* g++.dg/warn/Wsequence-point-4.C: New test.
Diffstat (limited to 'gcc/ada/gcc-interface/utils.c')
0 files changed, 0 insertions, 0 deletions