diff options
author | Thomas Schwinge <thomas@codesourcery.com> | 2021-09-21 08:54:49 +0200 |
---|---|---|
committer | Thomas Schwinge <thomas@codesourcery.com> | 2021-09-21 12:38:44 +0200 |
commit | e87789f197e47259c94349821d3446f7d959e08f (patch) | |
tree | 162ed834715661ddbf2389ce359d2a7f969031fa /gcc/ada/gcc-interface/decl.c | |
parent | 4e7a92c0ff3871d955ca8fb133f869b216d7224d (diff) | |
download | gcc-e87789f197e47259c94349821d3446f7d959e08f.zip gcc-e87789f197e47259c94349821d3446f7d959e08f.tar.gz gcc-e87789f197e47259c94349821d3446f7d959e08f.tar.bz2 |
Evaluate 'random ()' to '0' in 'pass_omp_oacc_neuter_broadcast'
Julian Brown,
<http://mid.mail-archive.com/20210920134603.16459021@squid.athome>:
| [...] the randomness shouldn't be necessary for the
| correctness of the patch (i.e. it could just be "base = bounds_lo", or
| indeed folded into the line after).
|
| The "ar.invalid ()" case happens when we fail to allocate a block of
| memory in LDS space for broadcasting a particular set of variables,
| and trigger a fall-back path in the broadcasting code that adds extra
| barriers around the broadcast in question. I imagine I was thinking
| that adding randomness could mean we can "get lucky" sometimes and
| avoid needing those barriers in some cases, but in fact I don't think
| that was implemented, so the randomness is useless. (Or it could just
| have been leftover debug code... oops).
gcc/
PR other/102408
* omp-oacc-neuter-broadcast.cc (oacc_do_neutering): Evaluate
'random ()' to '0'.
Diffstat (limited to 'gcc/ada/gcc-interface/decl.c')
0 files changed, 0 insertions, 0 deletions