diff options
author | Bob Duff <duff@adacore.com> | 2016-07-04 10:46:47 +0000 |
---|---|---|
committer | Arnaud Charlet <charlet@gcc.gnu.org> | 2016-07-04 12:46:47 +0200 |
commit | e49de265efb67ef2e21cb5ca623b5de264a492b7 (patch) | |
tree | 59e829af6b49ae06a0922d9d543a16ee1dd5aa6e /gcc/ada/checks.adb | |
parent | 890975e3443c1977ff636a265d0ad82408e898aa (diff) | |
download | gcc-e49de265efb67ef2e21cb5ca623b5de264a492b7.zip gcc-e49de265efb67ef2e21cb5ca623b5de264a492b7.tar.gz gcc-e49de265efb67ef2e21cb5ca623b5de264a492b7.tar.bz2 |
sem_eval.adb (Decompose_Expr): Set 'out' parameters Kind and Cons to valid values, to avoid use of uninit vars.
2016-07-04 Bob Duff <duff@adacore.com>
* sem_eval.adb (Decompose_Expr): Set 'out' parameters
Kind and Cons to valid values, to avoid use of uninit vars.
(Extract_Length): Reorder the check to make it clearer that
we're depending on BOTH Ent1 and Ent2 to be Present.
* sem_aggr.adb (Resolve_Aggregate): Remove dead code.
(Check_Misspelled_Component): Remove exit statement, because
it's covered by the 'while' condition.
* checks.adb (Apply_Selected_Range_Checks): Remove useless
condition "or else not Checks_On".
(Selected_Range_Checks):
Initialize Known_LB and Known_HB to False, because they are
tested unconditionally; avoid use of uninit vars.
* frontend.adb (Frontend): Removed useless condition
"Operating_Mode = Check_Semantics and then", and added an Assert
to clarify why it was useless.
* prep.adb (Preprocess): Remove redundant condition. Add an
assertion.
* sem_ch10.adb (Analyze_Proper_Body): Moved redundant condition
"Original_Operating_Mode = Generate_Code" to an Assert.
(Process_Spec_Clauses, Process_Body_Clauses): Change parameters
from 'in out' to 'out', and don't initialize actuals.
* sem_ch12.adb (Is_In_Main_Unit): Removed useless condition
"Unum = Main_Unit or else".
(Save_Global_Descendant): Moved
redundant condition "D = Union_Id (No_List)" to an Assert.
* sem_ch4.adb (Check_Misspelled_Selector): Remove exit
statement, because it's covered by the 'while' condition.
(Analyze_Case_Expression): Initialize Wrong_Alt to Empty,
because it looks like it is used uninitialized otherwise.
* sem_ch6.adb (Check_Return_Subtype_Indication): Moved redundant
condition "not R_Type_Is_Anon_Access" to an Assert.
* sem_elim.adb (Line_Num_Match): Moved redundant condition
"Sloc_Trace (Idx) = '['" to an Assert.
* sem_util.adb (Compile_Time_Constraint_Error): Change "J" to
"J - 1". This code is trying to replace "?" with "<", but not if
the "?" is quoted, as in "'?", so we want to check the PREVIOUS
character for '''.
* snames.adb-tmpl (Is_Pragma_Name): Remove useless condition
"or else N = Name_Relative_Deadline". It's useless because
Name_Relative_Deadline is in the range First_Pragma_Name
.. Last_Pragma_Name.
* treepr.adb (Visit_Node): Moved redundant condition "D =
Union_Id (No_List)" to an Assert.
* sem_ch3.adb (Derive_Subprogram, Derive_Subprograms): Change
parameters from 'in out' to 'out'.
* errout.adb (Error_Msg_Internal): Replace redundant test with Assert.
* inline.adb (Add_Inlined_Body): Code cleanup.
From-SVN: r237972
Diffstat (limited to 'gcc/ada/checks.adb')
-rw-r--r-- | gcc/ada/checks.adb | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/gcc/ada/checks.adb b/gcc/ada/checks.adb index 961e4b5..d91d64b 100644 --- a/gcc/ada/checks.adb +++ b/gcc/ada/checks.adb @@ -3243,9 +3243,7 @@ package body Checks is -- on, then we want to delete the check, since it is not needed. -- We do this by replacing the if statement by a null statement - -- Why are we even generating checks if checks are turned off ??? - - elsif Do_Static or else not Checks_On then + elsif Do_Static then Remove_Warning_Messages (R_Cno); Rewrite (R_Cno, Make_Null_Statement (Loc)); end if; @@ -9650,8 +9648,8 @@ package body Checks is LB : Node_Id := Low_Bound (Ck_Node); HB : Node_Id := High_Bound (Ck_Node); - Known_LB : Boolean; - Known_HB : Boolean; + Known_LB : Boolean := False; + Known_HB : Boolean := False; Null_Range : Boolean; Out_Of_Range_L : Boolean; @@ -9673,9 +9671,6 @@ package body Checks is then LB := T_LB; Known_LB := True; - - else - Known_LB := False; end if; -- Likewise for the high bound @@ -9688,8 +9683,6 @@ package body Checks is then HB := T_HB; Known_HB := True; - else - Known_HB := False; end if; end if; |