aboutsummaryrefslogtreecommitdiff
path: root/contrib/git-commit-mklog.py
diff options
context:
space:
mode:
authorMartin Liska <mliska@suse.cz>2022-07-22 11:26:08 +0200
committerMartin Liska <mliska@suse.cz>2022-07-22 13:19:24 +0200
commit18ef76d3a1701c4dd7ab38ebda5c374b6bc13041 (patch)
tree41a6602d7b0a289e8c83aa377770ce4e8b68d41e /contrib/git-commit-mklog.py
parent786e51648bd9a6880339329380751809fb97cd6d (diff)
downloadgcc-18ef76d3a1701c4dd7ab38ebda5c374b6bc13041.zip
gcc-18ef76d3a1701c4dd7ab38ebda5c374b6bc13041.tar.gz
gcc-18ef76d3a1701c4dd7ab38ebda5c374b6bc13041.tar.bz2
Allow space in git commit-mklog args
contrib/ChangeLog: * git-commit-mklog.py: Do not parse -b argument. Pass mklog_args as json environment variable. * mklog.py: Parse GCC_MKLOG_ARGS and append it to sys.argv. * prepare-commit-msg: Do not append GCC_MKLOG_ARGS to args.
Diffstat (limited to 'contrib/git-commit-mklog.py')
-rwxr-xr-xcontrib/git-commit-mklog.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/contrib/git-commit-mklog.py b/contrib/git-commit-mklog.py
index eda3fc4..c7e90c8 100755
--- a/contrib/git-commit-mklog.py
+++ b/contrib/git-commit-mklog.py
@@ -24,6 +24,7 @@
# to mklog.py script.
import argparse
+import json
import os
import subprocess
@@ -32,8 +33,7 @@ if __name__ == '__main__':
myenv = os.environ.copy()
parser = argparse.ArgumentParser(description='git-commit-mklog wrapped')
- parser.add_argument('-b', '--pr-numbers', action='store',
- type=lambda arg: arg.split(','), nargs='?',
+ parser.add_argument('-b', '--pr-numbers',
help='Add the specified PRs (comma separated)')
parser.add_argument('-p', '--fill-up-bug-titles', action='store_true',
help='Download title of mentioned PRs')
@@ -44,12 +44,13 @@ if __name__ == '__main__':
myenv['GCC_FORCE_MKLOG'] = '1'
mklog_args = []
if args.pr_numbers:
- mklog_args.append(f'-b {",".join(args.pr_numbers)}')
+ mklog_args += ['-b', args.pr_numbers]
if args.fill_up_bug_titles:
mklog_args.append('-p')
if mklog_args:
- myenv['GCC_MKLOG_ARGS'] = ' '.join(mklog_args)
+ # wrap mklog arguments with JSON
+ myenv['GCC_MKLOG_ARGS'] = json.dumps(mklog_args)
if args.co:
for author in args.co.split(','):