diff options
author | Martin Liska <mliska@suse.cz> | 2021-10-18 10:44:11 +0200 |
---|---|---|
committer | Martin Liska <mliska@suse.cz> | 2021-10-18 11:07:14 +0200 |
commit | 85ce673378e7091ce603b033fac213a9d0d1f83a (patch) | |
tree | 91505bc08a6083b5d103aec823d0897bf7eefcd4 /contrib/gcc-changelog/git_commit.py | |
parent | 47e4ab6559dc857df66403824909b5ab73891fd2 (diff) | |
download | gcc-85ce673378e7091ce603b033fac213a9d0d1f83a.zip gcc-85ce673378e7091ce603b033fac213a9d0d1f83a.tar.gz gcc-85ce673378e7091ce603b033fac213a9d0d1f83a.tar.bz2 |
gcc-changelog: update error message location
contrib/ChangeLog:
* gcc-changelog/git_commit.py: Update location of
'bad parentheses wrapping'.
* gcc-changelog/test_email.py: Test it.
Diffstat (limited to 'contrib/gcc-changelog/git_commit.py')
-rwxr-xr-x | contrib/gcc-changelog/git_commit.py | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py index f26dc3b..cf29f76 100755 --- a/contrib/gcc-changelog/git_commit.py +++ b/contrib/gcc-changelog/git_commit.py @@ -217,7 +217,7 @@ class ChangeLogEntry: self.lines = [] self.files = [] self.file_patterns = [] - self.opened_parentheses = 0 + self.parentheses_stack = [] def parse_file_names(self): # Whether the content currently processed is between a star prefix the @@ -551,7 +551,7 @@ class GitCommit: m = star_prefix_regex.match(line) if m: if (len(m.group('spaces')) != 1 and - last_entry.opened_parentheses == 0): + not last_entry.parentheses_stack): msg = 'one space should follow asterisk' self.errors.append(Error(msg, line)) else: @@ -576,13 +576,13 @@ class GitCommit: def process_parentheses(self, last_entry, line): for c in line: if c == '(': - last_entry.opened_parentheses += 1 + last_entry.parentheses_stack.append(line) elif c == ')': - if last_entry.opened_parentheses == 0: + if not last_entry.parentheses_stack: msg = 'bad wrapping of parenthesis' self.errors.append(Error(msg, line)) else: - last_entry.opened_parentheses -= 1 + del last_entry.parentheses_stack[-1] def parse_file_names(self): for entry in self.changelog_entries: @@ -608,9 +608,9 @@ class GitCommit: def check_for_broken_parentheses(self): for entry in self.changelog_entries: - if entry.opened_parentheses != 0: + if entry.parentheses_stack: msg = 'bad parentheses wrapping' - self.errors.append(Error(msg, entry.lines[0])) + self.errors.append(Error(msg, entry.parentheses_stack[-1])) def get_file_changelog_location(self, changelog_file): for file in self.info.modified_files: |