aboutsummaryrefslogtreecommitdiff
path: root/contrib/gcc-changelog/git_commit.py
diff options
context:
space:
mode:
authorFrederik Harwath <frederik@codesourcery.com>2020-05-19 11:15:28 +0200
committerFrederik Harwath <frederik@codesourcery.com>2020-05-20 10:36:34 +0200
commit3bcaf16edd881b81324b6789f7b48ca365463156 (patch)
treeb5e61851721221a0ee8a5bbf4059c1c4b0eafde7 /contrib/gcc-changelog/git_commit.py
parent93db1f8055e58916cb8d1d2d6897ec6d6d7c7400 (diff)
downloadgcc-3bcaf16edd881b81324b6789f7b48ca365463156.zip
gcc-3bcaf16edd881b81324b6789f7b48ca365463156.tar.gz
gcc-3bcaf16edd881b81324b6789f7b48ca365463156.tar.bz2
contrib/gcc-changelog: Skip over review lines
git-check-commit.py does not know about "Reviewed-by", "Reviewed-on", and "Signed-off-by" lines and hence it expects those lines which follow the ChangeLog entries to be indented by a tab. This commit makes the script skip those lines. No further processing is attempted because the review information is not part of the ChangeLogs. contrib/ 2020-05-20 Frederik Harwath <frederik@codesourcery.com> * gcc-changelog/git_commit.py: Skip over lines starting with "Reviewed-by: ", "Reviewed-on: ", or "Signed-off-by: "
Diffstat (limited to 'contrib/gcc-changelog/git_commit.py')
-rwxr-xr-xcontrib/gcc-changelog/git_commit.py11
1 files changed, 10 insertions, 1 deletions
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 5cc8c4f..c9b8497 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -151,7 +151,12 @@ LINE_LIMIT = 100
TAB_WIDTH = 8
CO_AUTHORED_BY_PREFIX = 'co-authored-by: '
CHERRY_PICK_PREFIX = '(cherry picked from commit '
+REVIEWED_BY_PREFIX = 'reviewed-by: '
+REVIEWED_ON_PREFIX = 'reviewed-on: '
+SIGNED_OFF_BY_PREFIX = 'signed-off-by: '
+REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,\
+ SIGNED_OFF_BY_PREFIX)
class Error:
def __init__(self, message, line=None):
@@ -345,11 +350,15 @@ class GitCommit:
else:
pr_line = line.lstrip()
- if line.lower().startswith(CO_AUTHORED_BY_PREFIX):
+
+ lowered_line = line.lower()
+ if lowered_line.startswith(CO_AUTHORED_BY_PREFIX):
name = line[len(CO_AUTHORED_BY_PREFIX):]
author = self.format_git_author(name)
self.co_authors.append(author)
continue
+ elif lowered_line.startswith(REVIEW_PREFIXES):
+ continue
elif line.startswith(CHERRY_PICK_PREFIX):
continue