diff options
| author | Jeff Law <jlaw@ventanamicro.com> | 2024-05-19 09:56:16 -0600 |
|---|---|---|
| committer | Jeff Law <jlaw@ventanamicro.com> | 2024-05-19 09:56:16 -0600 |
| commit | e1ce9c37ed68136a99d44c8301990c184ba41849 (patch) | |
| tree | 50edb12b0b480d6a04d54582adca82061b7954c4 | |
| parent | 1073469074ff132478ec8d923ed8635c672f7d9b (diff) | |
| download | gcc-e1ce9c37ed68136a99d44c8301990c184ba41849.zip gcc-e1ce9c37ed68136a99d44c8301990c184ba41849.tar.gz gcc-e1ce9c37ed68136a99d44c8301990c184ba41849.tar.bz2 | |
[to-be-committed][RISC-V][PR target/115142] Do not create invalidate shift-add insn
The circumstances which triggered this weren't something that should appear in
the wild (-ftree-ter, without optimization enabled). So I wasn't planning to
backport. Obviously if it shows up in another context we can revisit that
decision.
I've run this through my rv32gcv and rv64gc tester. Waiting on the CI system before committing.
PR target/115142
gcc/
* config/riscv/riscv.cc (mem_shadd_or_shadd_rtx_p): Make sure
shifted argument is a register.
gcc/testsuite
* gcc.target/riscv/pr115142.c: New test.
| -rw-r--r-- | gcc/config/riscv/riscv.cc | 1 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/riscv/pr115142.c | 10 |
2 files changed, 11 insertions, 0 deletions
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 7a34b4b..d0c2205 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -2465,6 +2465,7 @@ mem_shadd_or_shadd_rtx_p (rtx x) { return ((GET_CODE (x) == ASHIFT || GET_CODE (x) == MULT) + && register_operand (XEXP (x, 0), GET_MODE (x)) && CONST_INT_P (XEXP (x, 1)) && ((GET_CODE (x) == ASHIFT && IN_RANGE (INTVAL (XEXP (x, 1)), 1, 3)) || (GET_CODE (x) == MULT diff --git a/gcc/testsuite/gcc.target/riscv/pr115142.c b/gcc/testsuite/gcc.target/riscv/pr115142.c new file mode 100644 index 0000000..40ba49d --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/pr115142.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-O0 -ftree-ter" } */ + +long a; +char b; +void e() { + char f[8][1]; + b = f[a][a]; +} + |