aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Duff <duff@adacore.com>2019-12-16 10:35:24 +0000
committerPierre-Marie de Rodat <pmderodat@gcc.gnu.org>2019-12-16 10:35:24 +0000
commit495cdc79fb629750a71d5b1b1258425c3c3ebc58 (patch)
treea77658da8958cef7417d79b226f43cb903e331c8
parent9aaea2cc4b1a106e3a49ac9230c8d2e83e45dcc9 (diff)
downloadgcc-495cdc79fb629750a71d5b1b1258425c3c3ebc58.zip
gcc-495cdc79fb629750a71d5b1b1258425c3c3ebc58.tar.gz
gcc-495cdc79fb629750a71d5b1b1258425c3c3ebc58.tar.bz2
[Ada] Minor: improve comments
2019-12-16 Bob Duff <duff@adacore.com> gcc/ada/ * errout.adb, errout.ads: Improve comments. From-SVN: r279440
-rw-r--r--gcc/ada/ChangeLog4
-rw-r--r--gcc/ada/errout.adb3
-rw-r--r--gcc/ada/errout.ads7
3 files changed, 11 insertions, 3 deletions
diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index 9a422d8..0f94e40 100644
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,5 +1,9 @@
2019-12-16 Bob Duff <duff@adacore.com>
+ * errout.adb, errout.ads: Improve comments.
+
+2019-12-16 Bob Duff <duff@adacore.com>
+
* sem_util.ads: Minor comment fix.
2019-12-16 Bob Duff <duff@adacore.com>
diff --git a/gcc/ada/errout.adb b/gcc/ada/errout.adb
index 46e223f..db3393c 100644
--- a/gcc/ada/errout.adb
+++ b/gcc/ada/errout.adb
@@ -1716,9 +1716,12 @@ package body Errout is
function Is_Size_Too_Small_Message (S : String) return Boolean is
Size_For : constant String := "size for";
+ pragma Assert (Size_Too_Small_Message (1 .. Size_For'Last) = Size_For);
+ -- Assert that Size_Too_Small_Message starts with Size_For
begin
return S'Length >= Size_For'Length
and then S (S'First .. S'First + Size_For'Length - 1) = Size_For;
+ -- True if S starts with Size_For
end Is_Size_Too_Small_Message;
-----------------
diff --git a/gcc/ada/errout.ads b/gcc/ada/errout.ads
index 64acff4..4cfb806 100644
--- a/gcc/ada/errout.ads
+++ b/gcc/ada/errout.ads
@@ -957,8 +957,9 @@ package Errout is
function Is_Size_Too_Small_Message (S : String) return Boolean;
Size_Too_Small_Message : constant String :=
"size for& too small, minimum allowed is ^";
- -- This message is explicitly tested in Special_Msg_Delete in the package
- -- body, which is somewhat questionable, but at least by using a constant
- -- we are obeying the DRY principle.
+ -- This message is printed in Freeze and Sem_Ch13. We also test for it in
+ -- the body of this package (see Special_Msg_Delete) ???which is somewhat
+ -- questionable. The Is_Size_Too_Small_Message function tests for it by
+ -- testing a prefix. The function and constant should be kept in synch.
end Errout;