aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoern Rennecke <joern.rennecke@embecosm.com>2013-04-10 09:54:25 +0000
committerJoern Rennecke <amylaar@gcc.gnu.org>2013-04-10 10:54:25 +0100
commitee8a9b7b507013b0431cabd314a245461c3b86b9 (patch)
tree1fe05c42b5420c41fb7bc6483e954ffd10927339
parent6957a6f6f90ef5be56e154ee7ce8656ec0248e6f (diff)
downloadgcc-ee8a9b7b507013b0431cabd314a245461c3b86b9.zip
gcc-ee8a9b7b507013b0431cabd314a245461c3b86b9.tar.gz
gcc-ee8a9b7b507013b0431cabd314a245461c3b86b9.tar.bz2
re PR tree-optimization/55524 (If fnma exists but not fms, convert_mult_to_fma should prefer to former over the latter.)
gcc: 2013-04-10 Joern Rennecke <joern.rennecke@embecosm.com> PR tree-optimization/55524 * tree-ssa-math-opts.c (convert_mult_to_fma): Don't use an fms construct when we don't have an fms operation, but fnma, and it looks likely that we'll be able to use the latter. gcc/testsuite: 2013-04-10 Joern Rennecke <joern.rennecke@embecosm.com> PR tree-optimization/55524 * gcc.target/epiphany/fnma-1.c: New test. From-SVN: r197668
-rw-r--r--gcc/ChangeLog8
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.target/epiphany/fnma-1.c9
-rw-r--r--gcc/tree-ssa-math-opts.c18
4 files changed, 40 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b8a6789..98c6462 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+2013-04-10 Joern Rennecke <joern.rennecke@embecosm.com>
+
+ PR tree-optimization/55524
+ * tree-ssa-math-opts.c
+ (convert_mult_to_fma): Don't use an fms construct
+ when we don't have an fms operation, but fnma, and it looks
+ likely that we'll be able to use the latter.
+
2013-04-10 Zhouyi Zhou <yizhouzhou@ict.ac.cn>
* cif-code.def (OVERWRITABLE): Correct the comment for overwritable
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 13585fc..aacd009 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2013-04-10 Joern Rennecke <joern.rennecke@embecosm.com>
+
+ PR tree-optimization/55524
+ * gcc.target/epiphany/fnma-1.c: New test.
+
2013-04-10 Zhouyi Zhou <yizhouzhou@ict.ac.cn>
* gcc.dg/tree-ssa/inline-11.c: New test
diff --git a/gcc/testsuite/gcc.target/epiphany/fnma-1.c b/gcc/testsuite/gcc.target/epiphany/fnma-1.c
new file mode 100644
index 0000000..3155079
--- /dev/null
+++ b/gcc/testsuite/gcc.target/epiphany/fnma-1.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+/* { dg-final { scan-assembler-times "fmsub\[ \ta-zA-Z0-9\]*," 1 } } */
+
+float
+f (float ar, float ai, float br, float bi)
+{
+ return ar * br - ai * bi;
+}
diff --git a/gcc/tree-ssa-math-opts.c b/gcc/tree-ssa-math-opts.c
index 2140ced..e7e09f6 100644
--- a/gcc/tree-ssa-math-opts.c
+++ b/gcc/tree-ssa-math-opts.c
@@ -2570,6 +2570,24 @@ convert_mult_to_fma (gimple mul_stmt, tree op1, tree op2)
return false;
}
+ /* If the subtrahend (gimple_assign_rhs2 (use_stmt)) is computed
+ by a MULT_EXPR that we'll visit later, we might be able to
+ get a more profitable match with fnma.
+ OTOH, if we don't, a negate / fma pair has likely lower latency
+ that a mult / subtract pair. */
+ if (use_code == MINUS_EXPR && !negate_p
+ && gimple_assign_rhs1 (use_stmt) == result
+ && optab_handler (fms_optab, TYPE_MODE (type)) == CODE_FOR_nothing
+ && optab_handler (fnma_optab, TYPE_MODE (type)) != CODE_FOR_nothing)
+ {
+ tree rhs2 = gimple_assign_rhs2 (use_stmt);
+ gimple stmt2 = SSA_NAME_DEF_STMT (rhs2);
+
+ if (has_single_use (rhs2)
+ && gimple_assign_rhs_code (stmt2) == MULT_EXPR)
+ return false;
+ }
+
/* We can't handle a * b + a * b. */
if (gimple_assign_rhs1 (use_stmt) == gimple_assign_rhs2 (use_stmt))
return false;