aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexandre Oliva <oliva@adacore.com>2023-02-24 11:31:05 -0300
committerAlexandre Oliva <oliva@gnu.org>2023-02-24 11:31:05 -0300
commit3d1d3ece9bc5a1baa2feb4bf231b709c097b8434 (patch)
treef79eb6df3a9eacf66be5b888cced990ccf6c03b7
parent8520132bc362d5f915eb1cb20038492e37b3cf88 (diff)
downloadgcc-3d1d3ece9bc5a1baa2feb4bf231b709c097b8434.zip
gcc-3d1d3ece9bc5a1baa2feb4bf231b709c097b8434.tar.gz
gcc-3d1d3ece9bc5a1baa2feb4bf231b709c097b8434.tar.bz2
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets that use the AAPCS variant. ARM is the only target that overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way the clash between AAPCS and C++ Modules design should be resolved, but currently it favors AAPCS and thus the test fails, so skip it on arm_eabi. for gcc/testsuite/ChangeLog PR c++/105224 * g++.dg/modules/virt-2_a.C: Skip on arm_eabi.
-rw-r--r--gcc/testsuite/g++.dg/modules/virt-2_a.C3
1 files changed, 3 insertions, 0 deletions
diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C b/gcc/testsuite/g++.dg/modules/virt-2_a.C
index 580552b..b505044 100644
--- a/gcc/testsuite/g++.dg/modules/virt-2_a.C
+++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C
@@ -1,3 +1,6 @@
+// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE,
+// in a way that invalidates this test.
+// { dg-skip-if "!TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } }
// { dg-module-do run }
// { dg-additional-options -fmodules-ts }
export module foo;