diff options
| author | Marek Polacek <polacek@redhat.com> | 2013-04-04 15:48:25 +0000 |
|---|---|---|
| committer | Marek Polacek <mpolacek@gcc.gnu.org> | 2013-04-04 15:48:25 +0000 |
| commit | 39c1b6dbf50f2e634209365b4fb0b8a2b8edfbbf (patch) | |
| tree | a8aa0c1aee04fa4517748ac0f2623d515377254b | |
| parent | 314f64eb7d26e60585c0b5e2f8496d7cb1a81187 (diff) | |
| download | gcc-39c1b6dbf50f2e634209365b4fb0b8a2b8edfbbf.zip gcc-39c1b6dbf50f2e634209365b4fb0b8a2b8edfbbf.tar.gz gcc-39c1b6dbf50f2e634209365b4fb0b8a2b8edfbbf.tar.bz2 | |
re PR tree-optimization/48186 (ICE: SIGFPE (division by zero) in maybe_hot_frequency_p at predict.c:129 with --param hot-bb-frequency-fraction=0 on basic code)
PR tree-optimization/48186
* predict.c (maybe_hot_frequency_p): Return false if
HOT_BB_FREQUENCY_FRACTION is 0.
(cgraph_maybe_hot_edge_p): Likewise.
* gcc.dg/pr48186.c: New test.
From-SVN: r197487
| -rw-r--r-- | gcc/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/predict.c | 13 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr48186.c | 5 |
4 files changed, 26 insertions, 4 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 970c0d9..d301109 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2013-04-04 Marek Polacek <polacek@redhat.com> + + PR tree-optimization/48186 + * predict.c (maybe_hot_frequency_p): Return false if + HOT_BB_FREQUENCY_FRACTION is 0. + (cgraph_maybe_hot_edge_p): Likewise. + 2013-04-04 Richard Biener <rguenther@suse.de> PR tree-optimization/56826 diff --git a/gcc/predict.c b/gcc/predict.c index 52a4bb4..1871976 100644 --- a/gcc/predict.c +++ b/gcc/predict.c @@ -122,6 +122,8 @@ maybe_hot_frequency_p (struct function *fun, int freq) if (node->frequency == NODE_FREQUENCY_EXECUTED_ONCE && freq < (ENTRY_BLOCK_PTR_FOR_FUNCTION (fun)->frequency * 2 / 3)) return false; + if (PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION) == 0) + return false; if (freq < (ENTRY_BLOCK_PTR_FOR_FUNCTION (fun)->frequency / PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION))) return false; @@ -202,10 +204,13 @@ cgraph_maybe_hot_edge_p (struct cgraph_edge *edge) if (edge->caller->frequency == NODE_FREQUENCY_EXECUTED_ONCE && edge->frequency < CGRAPH_FREQ_BASE * 3 / 2) return false; - if (flag_guess_branch_prob - && edge->frequency <= (CGRAPH_FREQ_BASE - / PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION))) - return false; + if (flag_guess_branch_prob) + { + if (PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION) == 0 + || edge->frequency <= (CGRAPH_FREQ_BASE + / PARAM_VALUE (HOT_BB_FREQUENCY_FRACTION))) + return false; + } return true; } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a65b101..b2ca50b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-04-04 Marek Polacek <polacek@redhat.com> + + PR tree-optimization/48186 + * gcc.dg/pr48186.c: New test. + 2013-04-04 Richard Biener <rguenther@suse.de> PR tree-optimization/56826 diff --git a/gcc/testsuite/gcc.dg/pr48186.c b/gcc/testsuite/gcc.dg/pr48186.c new file mode 100644 index 0000000..5635f93 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr48186.c @@ -0,0 +1,5 @@ +/* PR tree-optimization/48186 */ +/* { dg-do compile } */ +/* { dg-options "-O --param hot-bb-frequency-fraction=0" } */ + +void foo (void) { } |