diff options
| author | Vladimir Makarov <vmakarov@redhat.com> | 2013-10-30 15:04:39 +0000 |
|---|---|---|
| committer | Vladimir Makarov <vmakarov@gcc.gnu.org> | 2013-10-30 15:04:39 +0000 |
| commit | a26891f4f59a90038cab4067a06553d362c46de7 (patch) | |
| tree | 24232735fcd2223285a3411bc15f36b4c678ddd3 | |
| parent | 6ecb8b21c8dfe19fa43fca0d534c80991d0c2ccc (diff) | |
| download | gcc-a26891f4f59a90038cab4067a06553d362c46de7.zip gcc-a26891f4f59a90038cab4067a06553d362c46de7.tar.gz gcc-a26891f4f59a90038cab4067a06553d362c46de7.tar.bz2 | |
re PR target/58784 ([ARM] LRA legitimate address issue with misalign neon_store)
2013-10-30 Vladimir Makarov <vmakarov@redhat.com>
PR target/58784
* lra.c (check_rtl): Remove address check before LRA work.
2013-10-30 Vladimir Makarov <vmakarov@redhat.com>
PR target/58784
* gcc.target/arm/pr58784.c: New.
From-SVN: r204215
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/lra.c | 30 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/arm/pr58784.c | 18 |
4 files changed, 33 insertions, 25 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f62fcdd..9e96d84 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2013-10-30 Vladimir Makarov <vmakarov@redhat.com> + + PR target/58784 + * lra.c (check_rtl): Remove address check before LRA work. + 2013-10-30 Marc Glisse <marc.glisse@inria.fr> * tree-ssa-alias.c (ao_ref_init_from_ptr_and_size): Look for a @@ -2017,10 +2017,8 @@ restore_scratches (void) static void check_rtl (bool final_p) { - int i; basic_block bb; rtx insn; - lra_insn_recog_data_t id; lra_assert (! final_p || reload_completed); FOR_EACH_BB (bb) @@ -2036,31 +2034,13 @@ check_rtl (bool final_p) lra_assert (constrain_operands (1)); continue; } + /* LRA code is based on assumption that all addresses can be + correctly decomposed. LRA can generate reloads for + decomposable addresses. The decomposition code checks the + correctness of the addresses. So we don't need to check + the addresses here. */ if (insn_invalid_p (insn, false)) fatal_insn_not_found (insn); - if (asm_noperands (PATTERN (insn)) >= 0) - continue; - id = lra_get_insn_recog_data (insn); - /* The code is based on assumption that all addresses in - regular instruction are legitimate before LRA. The code in - lra-constraints.c is based on assumption that there is no - subreg of memory as an insn operand. */ - for (i = 0; i < id->insn_static_data->n_operands; i++) - { - rtx op = *id->operand_loc[i]; - - if (MEM_P (op) - && (GET_MODE (op) != BLKmode - || GET_CODE (XEXP (op, 0)) != SCRATCH) - && ! memory_address_p (GET_MODE (op), XEXP (op, 0)) - /* Some ports don't recognize the following addresses - as legitimate. Although they are legitimate if - they satisfies the constraints and will be checked - by insn constraints which we ignore here. */ - && GET_CODE (XEXP (op, 0)) != UNSPEC - && GET_RTX_CLASS (GET_CODE (XEXP (op, 0))) != RTX_AUTOINC) - fatal_insn_not_found (insn); - } } } #endif /* #ifdef ENABLE_CHECKING */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 5c5171d..3fd4591 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-10-30 Vladimir Makarov <vmakarov@redhat.com> + + PR target/58784 + * gcc.target/arm/pr58784.c: New. + 2013-10-30 Marc Glisse <marc.glisse@inria.fr> * gcc.dg/tree-ssa/alias-24.c: New file. diff --git a/gcc/testsuite/gcc.target/arm/pr58784.c b/gcc/testsuite/gcc.target/arm/pr58784.c new file mode 100644 index 0000000..e3ef950 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr58784.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-march=armv7-a -mfloat-abi=hard -mfpu=neon -marm -O2" } */ + +typedef struct __attribute__ ((__packed__)) +{ + char valueField[2]; +} ptp_tlv_t; +typedef struct __attribute__ ((__packed__)) +{ + char stepsRemoved; + ptp_tlv_t tlv[1]; +} ptp_message_announce_t; +int ptplib_send_announce(int sequenceId, int i) +{ + ptp_message_announce_t tx_packet; + ((long long *)tx_packet.tlv[0].valueField)[sequenceId] = i; + f(&tx_packet); +} |