aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWilco Dijkstra <wdijkstr@arm.com>2015-05-14 13:35:30 +0000
committerJiong Wang <jiwang@gcc.gnu.org>2015-05-14 13:35:30 +0000
commitfc8b587d7e3cac469d29a415149102858bf7faf8 (patch)
treec03c9f9fd75cd041254db4fe8ec2a0848e8726ab
parenta0c4531ccf06e9381083421e9e7c2bdf89aa7f13 (diff)
downloadgcc-fc8b587d7e3cac469d29a415149102858bf7faf8.zip
gcc-fc8b587d7e3cac469d29a415149102858bf7faf8.tar.gz
gcc-fc8b587d7e3cac469d29a415149102858bf7faf8.tar.bz2
[AArch64] Use conditional negate for abs
2015-05-14 Wilco Dijkstra <wdijkstr@arm.com> gcc/ * config/aarch64/aarch64.md (absdi2): Optimize abs expansion. (csneg3<mode>_insn): Enable expansion of pattern. gcc/testsuite/ * gcc.target/aarch64/abs_1.c (abs64): Update test for new abs expansion. (abs64_in_dreg): Likewise. From-SVN: r223197
-rw-r--r--gcc/ChangeLog5
-rw-r--r--gcc/config/aarch64/aarch64.md32
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.target/aarch64/abs_1.c5
4 files changed, 19 insertions, 28 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 1b78ca3..ba35c77 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-14 Wilco Dijkstra <wdijkstr@arm.com>
+
+ * config/aarch64/aarch64.md (absdi2): Optimize abs expansion.
+ (csneg3<mode>_insn): Enable expansion of pattern.
+
2015-05-14 Nick Clifton <nickc@redhat.com>
* config/rl78/rl78.c (rl78_select_section): Select the correct
diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md
index 1dbadc0..4817fae 100644
--- a/gcc/config/aarch64/aarch64.md
+++ b/gcc/config/aarch64/aarch64.md
@@ -2182,34 +2182,16 @@
[(set_attr "type" "alu_ext")]
)
-(define_insn_and_split "absdi2"
- [(set (match_operand:DI 0 "register_operand" "=&r,w")
- (abs:DI (match_operand:DI 1 "register_operand" "r,w")))]
+(define_expand "abs<mode>2"
+ [(match_operand:GPI 0 "register_operand" "")
+ (match_operand:GPI 1 "register_operand" "")]
""
- "@
- #
- abs\\t%d0, %d1"
- "reload_completed
- && GP_REGNUM_P (REGNO (operands[0]))
- && GP_REGNUM_P (REGNO (operands[1]))"
- [(const_int 0)]
{
- emit_insn (gen_rtx_SET (operands[0],
- gen_rtx_XOR (DImode,
- gen_rtx_ASHIFTRT (DImode,
- operands[1],
- GEN_INT (63)),
- operands[1])));
- emit_insn (gen_rtx_SET (operands[0],
- gen_rtx_MINUS (DImode,
- operands[0],
- gen_rtx_ASHIFTRT (DImode,
- operands[1],
- GEN_INT (63)))));
+ rtx ccreg = aarch64_gen_compare_reg (LT, operands[1], const0_rtx);
+ rtx x = gen_rtx_LT (VOIDmode, ccreg, const0_rtx);
+ emit_insn (gen_csneg3<mode>_insn (operands[0], x, operands[1], operands[1]));
DONE;
}
- [(set_attr "type" "alu_sreg")
- (set_attr "simd" "no,yes")]
)
(define_insn "neg<mode>2"
@@ -2888,7 +2870,7 @@
[(set_attr "type" "csel")]
)
-(define_insn "*csneg3<mode>_insn"
+(define_insn "csneg3<mode>_insn"
[(set (match_operand:GPI 0 "register_operand" "=r")
(if_then_else:GPI
(match_operand 1 "aarch64_comparison_operation" "")
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index ef46d50..504dc07 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-14 Wilco Dijkstra <wdijkstr@arm.com>
+
+ * gcc.target/aarch64/abs_1.c (abs64): Update test for new abs expansion.
+ (abs64_in_dreg): Likewise.
+
2015-05-14 Marek Polacek <polacek@redhat.com>
PR c/66066
diff --git a/gcc/testsuite/gcc.target/aarch64/abs_1.c b/gcc/testsuite/gcc.target/aarch64/abs_1.c
index 938bc84..11f1095 100644
--- a/gcc/testsuite/gcc.target/aarch64/abs_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/abs_1.c
@@ -7,15 +7,14 @@ extern void abort (void);
long long
abs64 (long long a)
{
- /* { dg-final { scan-assembler "eor\t" } } */
- /* { dg-final { scan-assembler "sub\t" } } */
+ /* { dg-final { scan-assembler "csneg\t" } } */
return llabs (a);
}
long long
abs64_in_dreg (long long a)
{
- /* { dg-final { scan-assembler "abs\td\[0-9\]+, d\[0-9\]+" } } */
+ /* { dg-final { scan-assembler "csneg\t" } } */
register long long x asm ("d8") = a;
register long long y asm ("d9");
asm volatile ("" : : "w" (x));