diff options
| author | Jan Hubicka <jh@suse.cz> | 2022-06-14 14:05:53 +0200 |
|---|---|---|
| committer | Jan Hubicka <jh@suse.cz> | 2022-06-14 14:05:53 +0200 |
| commit | 8f6c317b3a16350698f3c9e0accb43a9b4acb4ae (patch) | |
| tree | 174830d5fac2159ffe8a78df3f8fff266156b0c1 | |
| parent | 0247ad3e0f4a574273b42344fbaa9346599948f9 (diff) | |
| download | gcc-8f6c317b3a16350698f3c9e0accb43a9b4acb4ae.zip gcc-8f6c317b3a16350698f3c9e0accb43a9b4acb4ae.tar.gz gcc-8f6c317b3a16350698f3c9e0accb43a9b4acb4ae.tar.bz2 | |
Fix ipa-cp wrt volatile loads
Check for volatile flag to ipa_load_from_parm_agg.
gcc/ChangeLog:
2022-06-10 Jan Hubicka <hubicka@ucw.cz>
PR ipa/105739
* ipa-prop.cc (ipa_load_from_parm_agg): Punt on volatile loads.
gcc/testsuite/ChangeLog:
2022-06-10 Jan Hubicka <hubicka@ucw.cz>
* gcc.dg/ipa/pr105739.c: New test.
| -rw-r--r-- | gcc/ipa-prop.cc | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/ipa/pr105739.c | 30 |
2 files changed, 34 insertions, 0 deletions
diff --git a/gcc/ipa-prop.cc b/gcc/ipa-prop.cc index afd9222..c037668 100644 --- a/gcc/ipa-prop.cc +++ b/gcc/ipa-prop.cc @@ -1112,6 +1112,10 @@ ipa_load_from_parm_agg (struct ipa_func_body_info *fbi, if (!base) return false; + /* We can not propagate across volatile loads. */ + if (TREE_THIS_VOLATILE (op)) + return false; + if (DECL_P (base)) { int index = ipa_get_param_decl_index_1 (descriptors, base); diff --git a/gcc/testsuite/gcc.dg/ipa/pr105739.c b/gcc/testsuite/gcc.dg/ipa/pr105739.c new file mode 100644 index 0000000..8dbe8fc --- /dev/null +++ b/gcc/testsuite/gcc.dg/ipa/pr105739.c @@ -0,0 +1,30 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-optimized" } */ + + +__attribute__((noinline)) +static int +test2(int a) +{ + if (__builtin_constant_p (a)) + __builtin_abort (); + return a; +} +static int +test(int *a) +{ + int val = *(volatile int *)a; + if (__builtin_constant_p (val)) + __builtin_abort (); + if (val) + return test2(val); + return 0; +} +int a; +int +main() +{ + a = 0; + return test (&a); +} +/* { dg-final { scan-tree-dump "test2" "optimized" } } */ |