aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Biener <rguenther@suse.de>2024-06-17 14:36:56 +0200
committerRichard Biener <rguenther@suse.de>2024-06-21 11:42:48 +0200
commit65e25860f49ee7a2cfd4872db06d94ed7675e12e (patch)
tree1444d8692d601f0c2eb4308353893fe9556c185d
parent85d32e6f75e7395c12b9979a47b70fe9479ca1ff (diff)
downloadgcc-65e25860f49ee7a2cfd4872db06d94ed7675e12e.zip
gcc-65e25860f49ee7a2cfd4872db06d94ed7675e12e.tar.gz
gcc-65e25860f49ee7a2cfd4872db06d94ed7675e12e.tar.bz2
tree-optimization/115508 - fix ICE with SLP scheduling and extern vector
When there's a permute after an extern vector we can run into a case that didn't consider the scheduled node being a permute which lacks a representative. PR tree-optimization/115508 * tree-vect-slp.cc (vect_schedule_slp_node): Guard check on representative. * gcc.target/i386/pr115508.c: New testcase. (cherry picked from commit 65e72b95c63a5501cf1482f3814ae8c8e672bf06)
-rw-r--r--gcc/testsuite/gcc.target/i386/pr115508.c15
-rw-r--r--gcc/tree-vect-slp.cc1
2 files changed, 16 insertions, 0 deletions
diff --git a/gcc/testsuite/gcc.target/i386/pr115508.c b/gcc/testsuite/gcc.target/i386/pr115508.c
new file mode 100644
index 0000000..a97b200
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr115508.c
@@ -0,0 +1,15 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -march=znver1" } */
+
+typedef long long v4di __attribute__((vector_size(4 * sizeof (long long))));
+
+v4di vec_var;
+extern long long array1[];
+long long g(void)
+{
+ int total_error_4 = 0;
+ total_error_4 += array1 [0] + array1 [1] + array1 [2] + array1 [3];
+ v4di t = vec_var;
+ long long iorvar = t [1] | t [0] | t [2] | t [3];
+ return iorvar + total_error_4;
+}
diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
index e55191c..5e7e9b5 100644
--- a/gcc/tree-vect-slp.cc
+++ b/gcc/tree-vect-slp.cc
@@ -9395,6 +9395,7 @@ vect_schedule_slp_node (vec_info *vinfo,
si = gsi_after_labels (as_a <bb_vec_info> (vinfo)->bbs[0]);
}
else if (is_a <bb_vec_info> (vinfo)
+ && SLP_TREE_CODE (node) != VEC_PERM_EXPR
&& gimple_bb (last_stmt) != gimple_bb (stmt_info->stmt)
&& gimple_could_trap_p (stmt_info->stmt))
{