diff options
| author | Jason Merrill <jason@redhat.com> | 2022-01-24 00:01:40 -0500 |
|---|---|---|
| committer | Jason Merrill <jason@redhat.com> | 2022-01-25 14:28:13 -0500 |
| commit | fe5cee6f62a0b229d9d51616b7490331d39b5ddd (patch) | |
| tree | 19f36ed614a0e14b4d8f1e5b536d490c80e790ad | |
| parent | aeac414923aa1e87986c7fc6f9b921d89a9b86cf (diff) | |
| download | gcc-fe5cee6f62a0b229d9d51616b7490331d39b5ddd.zip gcc-fe5cee6f62a0b229d9d51616b7490331d39b5ddd.tar.gz gcc-fe5cee6f62a0b229d9d51616b7490331d39b5ddd.tar.bz2 | |
c++: assignment to temporary [PR59950]
Given build_this of a TARGET_EXPR, cp_build_fold_indirect_ref returns the
TARGET_EXPR. But that's the wrong value category for the result of the
defaulted class assignment operator, which returns an lvalue, so we need to
actually build the INDIRECT_REF.
PR c++/59950
gcc/cp/ChangeLog:
* call.cc (build_over_call): Use cp_build_indirect_ref.
gcc/testsuite/ChangeLog:
* g++.dg/init/assign2.C: New test.
| -rw-r--r-- | gcc/cp/call.cc | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/init/assign2.C | 6 |
2 files changed, 10 insertions, 1 deletions
diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc index f7f861c..bc157cd 100644 --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -9789,7 +9789,10 @@ build_over_call (struct z_candidate *cand, int flags, tsubst_flags_t complain) && DECL_OVERLOADED_OPERATOR_IS (fn, NOP_EXPR) && trivial_fn_p (fn)) { - tree to = cp_build_fold_indirect_ref (argarray[0]); + /* Don't use cp_build_fold_indirect_ref, op= returns an lvalue even if + the object argument isn't one. */ + tree to = cp_build_indirect_ref (input_location, argarray[0], + RO_ARROW, complain); tree type = TREE_TYPE (to); tree as_base = CLASSTYPE_AS_BASE (type); tree arg = argarray[1]; diff --git a/gcc/testsuite/g++.dg/init/assign2.C b/gcc/testsuite/g++.dg/init/assign2.C new file mode 100644 index 0000000..72d1264 --- /dev/null +++ b/gcc/testsuite/g++.dg/init/assign2.C @@ -0,0 +1,6 @@ +// PR c++/59950 + + struct Foo {}; + + int f(Foo *p); + int n = f(&(Foo() = Foo())); |