aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Wakely <jwakely@redhat.com>2021-06-14 22:42:05 +0100
committerJonathan Wakely <jwakely@redhat.com>2021-06-14 23:13:16 +0100
commitf9598d89a9f5a327ecdfa6f6978a0cfbe4447111 (patch)
tree3fa476b0cbb1a2f8c977bdd93a6959a898f9b0ab
parent20073534c0ccca0a4e079c053ee0874af10b2ea0 (diff)
downloadgcc-f9598d89a9f5a327ecdfa6f6978a0cfbe4447111.zip
gcc-f9598d89a9f5a327ecdfa6f6978a0cfbe4447111.tar.gz
gcc-f9598d89a9f5a327ecdfa6f6978a0cfbe4447111.tar.bz2
libstdc++: Fix noexcept-specifier for ranges::empty
Signed-off-by: Jonathan Wakely <jwakely@redhat.com> libstdc++-v3/ChangeLog: * include/bits/ranges_base.h (ranges::empty): Check whether conversion to bool can throw. * testsuite/std/ranges/access/empty.cc: Check for correct noexcept-specifier.
-rw-r--r--libstdc++-v3/include/bits/ranges_base.h2
-rw-r--r--libstdc++-v3/testsuite/std/ranges/access/empty.cc31
2 files changed, 32 insertions, 1 deletions
diff --git a/libstdc++-v3/include/bits/ranges_base.h b/libstdc++-v3/include/bits/ranges_base.h
index 728d3ad..3bc657c 100644
--- a/libstdc++-v3/include/bits/ranges_base.h
+++ b/libstdc++-v3/include/bits/ranges_base.h
@@ -476,7 +476,7 @@ namespace ranges
_S_noexcept()
{
if constexpr (__member_empty<_Tp>)
- return noexcept(std::declval<_Tp&>().empty());
+ return noexcept(bool(std::declval<_Tp&>().empty()));
else if constexpr (__size0_empty<_Tp>)
return noexcept(_Size{}(std::declval<_Tp&>()) == 0);
else
diff --git a/libstdc++-v3/testsuite/std/ranges/access/empty.cc b/libstdc++-v3/testsuite/std/ranges/access/empty.cc
index 9044dd1..b2d8b10 100644
--- a/libstdc++-v3/testsuite/std/ranges/access/empty.cc
+++ b/libstdc++-v3/testsuite/std/ranges/access/empty.cc
@@ -89,10 +89,41 @@ test03()
static_assert( std::ranges::empty(R2{}) );
}
+void
+test04()
+{
+ struct E1
+ {
+ bool empty() const noexcept { return {}; }
+ };
+
+ static_assert( noexcept(std::ranges::empty(E1{})) );
+
+ struct E2
+ {
+ bool empty() const noexcept(false) { return {}; }
+ };
+
+ static_assert( ! noexcept(std::ranges::empty(E2{})) );
+
+ struct E3
+ {
+ struct B
+ {
+ explicit operator bool() const noexcept(false) { return true; }
+ };
+
+ B empty() const noexcept { return {}; }
+ };
+
+ static_assert( ! noexcept(std::ranges::empty(E3{})) );
+}
+
int
main()
{
test01();
test02();
test03();
+ test04();
}