diff options
| author | Martin Sebor <msebor@redhat.com> | 2019-10-08 22:12:54 +0000 |
|---|---|---|
| committer | Martin Sebor <msebor@gcc.gnu.org> | 2019-10-08 16:12:54 -0600 |
| commit | d470060d06c45592514858b0a4c87bd71cd91c9b (patch) | |
| tree | 3fbcdf9f9bc970fb4a93744bba6db18b06581974 | |
| parent | 0eeb34b29937338a8087216c49d3837b69107238 (diff) | |
| download | gcc-d470060d06c45592514858b0a4c87bd71cd91c9b.zip gcc-d470060d06c45592514858b0a4c87bd71cd91c9b.tar.gz gcc-d470060d06c45592514858b0a4c87bd71cd91c9b.tar.bz2 | |
PR c++/92001 - missing -Wclass-memaccess with array as first argument to memset
gcc/cp/ChangeLog:
PR c++/92001
* call.c (maybe_warn_class_memaccess): Handle arrays.
gcc/testsuite/ChangeLog:
PR c++/92001
* g++.dg/Wclass-memaccess-5.C: New test.
From-SVN: r276725
| -rw-r--r-- | gcc/cp/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/cp/call.c | 4 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/Wclass-memaccess-5.C | 18 |
4 files changed, 31 insertions, 1 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 90cab94..0e8d930 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2019-10-08 Martin Sebor <msebor@redhat.com> + + PR c++/92001 + * call.c (maybe_warn_class_memaccess): Handle arrays. + 2019-10-07 Paolo Carlini <paolo.carlini@oracle.com> * call.c (resolve_args): Use cp_expr_loc_or_input_loc in one place. diff --git a/gcc/cp/call.c b/gcc/cp/call.c index 6c9acac..4ed424f 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -8911,7 +8911,9 @@ maybe_warn_class_memaccess (location_t loc, tree fndecl, unsigned srcidx = !dstidx; tree dest = (*args)[dstidx]; - if (!TREE_TYPE (dest) || !INDIRECT_TYPE_P (TREE_TYPE (dest))) + if (!TREE_TYPE (dest) + || (TREE_CODE (TREE_TYPE (dest)) != ARRAY_TYPE + && !INDIRECT_TYPE_P (TREE_TYPE (dest)))) return; tree srctype = NULL_TREE; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d9d73db..3f189e3 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-10-08 Martin Sebor <msebor@redhat.com> + + PR c++/92001 + * g++.dg/Wclass-memaccess-5.C: New test. + 2019-10-08 Dmitrij Pochepko <dmitrij.pochepko@bell-sw.com> PR tree-optimization/90836 diff --git a/gcc/testsuite/g++.dg/Wclass-memaccess-5.C b/gcc/testsuite/g++.dg/Wclass-memaccess-5.C new file mode 100644 index 0000000..d0fffea --- /dev/null +++ b/gcc/testsuite/g++.dg/Wclass-memaccess-5.C @@ -0,0 +1,18 @@ +/* PR c++/92001 - missing -Wclass-memaccess with array as first argument + to memset + { dg-do compile } + { dg-options "-Wall" } */ + +extern "C" void* memset (void*, int, __SIZE_TYPE__); + +struct S { S (); }; + +void test_array_access (S *p, S (*pa)[2], S (&r)[3]) +{ + S a[1]; + memset (a, 0, sizeof a); // { dg-warning "-Wclass-memaccess" } + + memset (*pa, 0, sizeof *pa); // { dg-warning "-Wclass-memaccess" } + + memset (r, 0, sizeof r); // { dg-warning "-Wclass-memaccess" } +} |