diff options
| author | Richard Biener <rguenther@suse.de> | 2016-03-09 16:41:19 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2016-03-09 16:41:19 +0000 |
| commit | c9e336624a5f3d3845b9b4a070f29d074418bd73 (patch) | |
| tree | 6eeff31f2bbd574cdd383c1442c4967fa3bd4748 | |
| parent | 2c73b7640dba91c6041404ab3e3b4f629ad73ad1 (diff) | |
| download | gcc-c9e336624a5f3d3845b9b4a070f29d074418bd73.zip gcc-c9e336624a5f3d3845b9b4a070f29d074418bd73.tar.gz gcc-c9e336624a5f3d3845b9b4a070f29d074418bd73.tar.bz2 | |
re PR tree-optimization/70138 (wrong code at -O3 on x86_64-linux-gnu)
2016-03-09 Richard Biener <rguenther@suse.de>
Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/70138
* tree-vect-loop-manip.c (vect_update_ivs_after_vectorizer):
Also skip vect_double_reduction_def.
* gcc.dg/vect/pr70138-1.c: New testcase.
* gcc.dg/vect/pr70138-2.c: Likewise.
Co-Authored-By: Jakub Jelinek <jakub@redhat.com>
From-SVN: r234086
| -rw-r--r-- | gcc/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vect/pr70138-1.c | 40 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vect/pr70138-2.c | 35 | ||||
| -rw-r--r-- | gcc/tree-vect-loop-manip.c | 3 |
5 files changed, 91 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c99bf64..e0e9ad1 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2016-03-09 Richard Biener <rguenther@suse.de> + Jakub Jelinek <jakub@redhat.com> + + PR tree-optimization/70138 + * tree-vect-loop-manip.c (vect_update_ivs_after_vectorizer): + Also skip vect_double_reduction_def. + 2016-03-09 Jakub Jelinek <jakub@redhat.com> PR target/70049 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 131ed75..b95a863 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2016-03-09 Richard Biener <rguenther@suse.de> + Jakub Jelinek <jakub@redhat.com> + + PR tree-optimization/70138 + * gcc.dg/vect/pr70138-1.c: New testcase. + * gcc.dg/vect/pr70138-2.c: Likewise. + 2016-03-09 Jakub Jelinek <jakub@redhat.com> PR target/70049 diff --git a/gcc/testsuite/gcc.dg/vect/pr70138-1.c b/gcc/testsuite/gcc.dg/vect/pr70138-1.c new file mode 100644 index 0000000..bd4d006 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr70138-1.c @@ -0,0 +1,40 @@ +/* { dg-do run } */ + +#include "tree-vect.h" + +double u[33 * 33]; + +__attribute__((noinline, noclone)) static void +foo (int *x) +{ + double c = 0.0; + int a, b; + for (a = 0; a < 33; a++) + { + for (b = 0; b < 33; b++) + c = c + u[34 * a]; + u[34 * a] *= 2.0; + } + *x = c; +} + +int +main () +{ + int d, e; + check_vect (); + for (d = 0; d < 33 * 33; d++) + { + u[d] = 499.0; + __asm__ volatile ("" : : : "memory"); + } + for (d = 0; d < 33; d++) + { + u[d * 34] = (d + 2); + __asm__ volatile ("" : : : "memory"); + } + foo (&e); + if (e != 33 * (2 + 34) / 2 * 33) + __builtin_abort (); + return 0; +} diff --git a/gcc/testsuite/gcc.dg/vect/pr70138-2.c b/gcc/testsuite/gcc.dg/vect/pr70138-2.c new file mode 100644 index 0000000..b1f9737 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr70138-2.c @@ -0,0 +1,35 @@ +/* { dg-do run } */ + +#include "tree-vect.h" + +double u[33]; + +__attribute__((noinline, noclone)) static void +foo (int *x) +{ + double c = 0.0; + int a, b; + for (a = 0; a < 33; a++) + { + for (b = 0; b < 33; b++) + c = c + u[a]; + u[a] *= 2.0; + } + *x = c; +} + +int +main () +{ + int d, e; + check_vect (); + for (d = 0; d < 33; d++) + { + u[d] = (d + 2); + __asm__ volatile ("" : : : "memory"); + } + foo (&e); + if (e != 33 * (2 + 34) / 2 * 33) + __builtin_abort (); + return 0; +} diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c index f8a44b5..7ec6dae 100644 --- a/gcc/tree-vect-loop-manip.c +++ b/gcc/tree-vect-loop-manip.c @@ -1692,7 +1692,8 @@ vect_update_ivs_after_vectorizer (loop_vec_info loop_vinfo, tree niters, /* Skip reduction phis. */ stmt_info = vinfo_for_stmt (phi); - if (STMT_VINFO_DEF_TYPE (stmt_info) == vect_reduction_def) + if (STMT_VINFO_DEF_TYPE (stmt_info) == vect_reduction_def + || STMT_VINFO_DEF_TYPE (stmt_info) == vect_double_reduction_def) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, |