diff options
| author | Iain Sandoe <iain@sandoe.co.uk> | 2019-05-21 16:24:25 +0000 |
|---|---|---|
| committer | Iain Sandoe <iains@gcc.gnu.org> | 2019-05-21 16:24:25 +0000 |
| commit | 9f0c354752add19ae043a9f4960bde1142adb23d (patch) | |
| tree | e04cceeaeb877c514cefcafde6a88f6bacd9e811 | |
| parent | c54eb7f40ce09bc22aca2aea7cdde6e286249ada (diff) | |
| download | gcc-9f0c354752add19ae043a9f4960bde1142adb23d.zip gcc-9f0c354752add19ae043a9f4960bde1142adb23d.tar.gz gcc-9f0c354752add19ae043a9f4960bde1142adb23d.tar.bz2 | |
darwin, testsuite - fix PR 63891.
This is a testcase failing because one part of the codegen is
(correctly) generating the scan-asm-not signature.
Fixed by altering the build options.
gcc/testsuite/
2019-05-18 Iain Sandoe <iain@sandoe.co.uk>
PR target/63891
* gcc.dg/darwin-weakimport-3.c: Adjust options and explain
the reasons.
From-SVN: r271474
| -rw-r--r-- | gcc/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/darwin-weakimport-3.c | 17 |
2 files changed, 22 insertions, 1 deletions
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 6206ef5..d14dc1b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2019-05-18 Iain Sandoe <iain@sandoe.co.uk> + + PR target/63891 + * gcc.dg/darwin-weakimport-3.c: Adjust options and explain + the reasons. + 2019-05-21 Uroš Bizjak <ubizjak@gmail.com> * gcc.target/i386/vect-signbitf.c: New test. diff --git a/gcc/testsuite/gcc.dg/darwin-weakimport-3.c b/gcc/testsuite/gcc.dg/darwin-weakimport-3.c index 77ab980..a15b5b0 100644 --- a/gcc/testsuite/gcc.dg/darwin-weakimport-3.c +++ b/gcc/testsuite/gcc.dg/darwin-weakimport-3.c @@ -1,5 +1,20 @@ /* { dg-do compile { target *-*-darwin* } } */ -/* { dg-options "-fno-asynchronous-unwind-tables" } */ + +/* Here we want to test if "foo" gets placed into a coalesced + section (it should not). + + However, for i386, and PIC code we have a "get_pc thunk" that + is (correctly) placed in a coalesced section when using an older + linker - also unwind tables are emitted into coalesced. + + With modern linkers this is moot, since even weak symbols + are emitted into the regular sections. + + To avoid the unwind tables -fno-asynchronous-unwind-tables. + To ensure that we emit code for an older linker -mtarget-linker + To avoid the get_pc thunk optimise at least O1. */ + +/* { dg-options "-fno-asynchronous-unwind-tables -O1 -mtarget-linker 85.2" } */ /* { dg-require-weak "" } */ /* { dg-final { scan-assembler-not "coalesced" } } */ |