diff options
author | Andrew MacLeod <amacleod@redhat.com> | 2020-10-21 20:11:16 -0400 |
---|---|---|
committer | Andrew MacLeod <amacleod@redhat.com> | 2020-10-21 20:15:28 -0400 |
commit | 966fdb2e12c0347aa3f9efaf5f4e1cd8237fa024 (patch) | |
tree | 75e85ac0b6215c99666bc3368d246c2318e5ba09 | |
parent | 0f41b5e02fa47db2080b77e4e1f7cd3305457c05 (diff) | |
download | gcc-966fdb2e12c0347aa3f9efaf5f4e1cd8237fa024.zip gcc-966fdb2e12c0347aa3f9efaf5f4e1cd8237fa024.tar.gz gcc-966fdb2e12c0347aa3f9efaf5f4e1cd8237fa024.tar.bz2 |
Handle a_2= &b properly in range calculations.
when processing assignments, we were using the type of b instead of type
of &b when computing a range. This was usually filtered out by FRE.
turning it off exposed it.
gcc/
PR tree-optimization/97520
* gimple-range.cc (range_of_non_trivial_assignment): Handle x = &a
by returning a non-zero range.
gcc/testsuite/
* gcc.dg/pr97520.c: New.
-rw-r--r-- | gcc/gimple-range.cc | 32 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/pr97520.c | 11 |
2 files changed, 34 insertions, 9 deletions
diff --git a/gcc/gimple-range.cc b/gcc/gimple-range.cc index c5520e0..267ebad 100644 --- a/gcc/gimple-range.cc +++ b/gcc/gimple-range.cc @@ -446,17 +446,31 @@ gimple_ranger::range_of_non_trivial_assignment (irange &r, gimple *stmt) return false; tree base = gimple_range_base_of_assignment (stmt); - if (base && TREE_CODE (base) == MEM_REF - && TREE_CODE (TREE_OPERAND (base, 0)) == SSA_NAME) + if (base) { - int_range_max range1; - tree ssa = TREE_OPERAND (base, 0); - if (range_of_expr (range1, ssa, stmt)) + if (TREE_CODE (base) == MEM_REF) { - tree type = TREE_TYPE (ssa); - range_operator *op = range_op_handler (POINTER_PLUS_EXPR, type); - int_range<2> offset (TREE_OPERAND (base, 1), TREE_OPERAND (base, 1)); - op->fold_range (r, type, range1, offset); + if (TREE_CODE (TREE_OPERAND (base, 0)) == SSA_NAME) + { + int_range_max range1; + tree ssa = TREE_OPERAND (base, 0); + if (range_of_expr (range1, ssa, stmt)) + { + tree type = TREE_TYPE (ssa); + range_operator *op = range_op_handler (POINTER_PLUS_EXPR, + type); + int_range<2> offset (TREE_OPERAND (base, 1), + TREE_OPERAND (base, 1)); + op->fold_range (r, type, range1, offset); + return true; + } + } + return false; + } + if (gimple_assign_rhs_code (stmt) == ADDR_EXPR) + { + // Handle "= &a" and return non-zero. + r = range_nonzero (TREE_TYPE (gimple_assign_rhs1 (stmt))); return true; } } diff --git a/gcc/testsuite/gcc.dg/pr97520.c b/gcc/testsuite/gcc.dg/pr97520.c new file mode 100644 index 0000000..9f66595 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr97520.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fno-tree-fre" } */ + +char a; +void b() { + char *c[5]; + char *d = &a; + &d; + *(c[4] = d); +} +int main() { return 0; } |