diff options
| author | Jonathan Wakely <jwakely@redhat.com> | 2021-03-04 10:28:38 +0000 |
|---|---|---|
| committer | Jonathan Wakely <jwakely@redhat.com> | 2021-03-04 10:31:27 +0000 |
| commit | 905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77 (patch) | |
| tree | 9d8cdf5b5bdbdee7ae3b460beb38ba17fadb9658 | |
| parent | f65e551f737ee3cb3a6ae45bd8168d959feacfa1 (diff) | |
| download | gcc-905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77.zip gcc-905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77.tar.gz gcc-905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77.tar.bz2 | |
libstdc++: Fix buffer overflows in tests [PR 99382]
This seems to be a typo/thinko in the definition of the arrays used as
storage.
libstdc++-v3/ChangeLog:
PR libstdc++/99382
* testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc:
Make storage larger than required. Verify no write to the last
element.
* testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc:
Likewise.
2 files changed, 9 insertions, 2 deletions
diff --git a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc index fbe14d4..1a1aba4 100644 --- a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc +++ b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc @@ -41,10 +41,12 @@ test02() int operator>(void*) { return value != 0; } }; - int i[3]; + int i[5] = { 1, 2, 3, 4, 5 }; Size n = {4}; auto j = std::__uninitialized_default_n(i, n); VERIFY( j == (i + 4) ); + // i[0:3] are default-initialized so have indeterminate values. + VERIFY( i[4] == 5 ); } int diff --git a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc index d227de4..5833f7e 100644 --- a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc +++ b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc @@ -42,10 +42,15 @@ test02() int operator>(void*) { return value != 0; } }; - int i[3]; + int i[5] = { 1, 2, 3, 4, 5 }; Size n = {4}; auto j = std::__uninitialized_default_n(i, n); VERIFY( j == (i + 4) ); + VERIFY( i[0] == 0 ); + VERIFY( i[1] == 0 ); + VERIFY( i[2] == 0 ); + VERIFY( i[3] == 0 ); + VERIFY( i[4] == 5 ); } int |